[PATCH v2 2/2] libcamera: libipa: camera_sensor: Add Sony IMX335 sensor properties

[Umang Jain]

Hi Jacopo,

On 02/05/24 9:00 pm, Jacopo Mondi wrote:
> Hi Umang
>
> On Fri, Apr 26, 2024 at 06:55:16PM +0530, Umang Jain wrote:
>> From: Kieran Bingham <kieran.bingham at ideasonboard.com>
>>
>> Provide the Sony IMX335 camera sensor properties and registration
>> with libipa for the gain code helpers.
>>
>> The test patterns exposed by the IMX335 do not map well to the current
>> set of test pattern controls supplied by libcamera. These are left
>> inentionally unimplemented.
> intentionally
>
> Do we have dumps of these test patterns (for this and the imx283) as
> the datahseet doesn't report them ?

we do have dumps of them and the latest imx335 driver does exposes them 
correctly.

See:
https://git.linuxtv.org/media_stage.git/commit/?id=37e83782f9dd7bb830ef4714f04fae6605e43221

We need appropriate mapping of libcamera test pattern modes that needs 
to be introduced (for both IMX283 and IMX335).

>
>
>> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
> Reviewed-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
>
> Thanks
>    j
>
>> ---
>>   src/ipa/libipa/camera_sensor_helper.cpp           | 11 +++++++++++
>>   src/libcamera/sensor/camera_sensor_properties.cpp |  4 ++++
>>   2 files changed, 15 insertions(+)
>>
>> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
>> index f70d898f..84d52d10 100644
>> --- a/src/ipa/libipa/camera_sensor_helper.cpp
>> +++ b/src/ipa/libipa/camera_sensor_helper.cpp
>> @@ -455,6 +455,17 @@ class CameraSensorHelperImx327 : public CameraSensorHelperImx290
>>   };
>>   REGISTER_CAMERA_SENSOR_HELPER("imx327", CameraSensorHelperImx327)
>>
>> +class CameraSensorHelperImx335 : public CameraSensorHelper
>> +{
>> +public:
>> +	CameraSensorHelperImx335()
>> +	{
>> +		gainType_ = AnalogueGainExponential;
>> +		gainConstants_.exp = { 1.0, expGainDb(0.3) };
>> +	}
>> +};
>> +REGISTER_CAMERA_SENSOR_HELPER("imx335", CameraSensorHelperImx335)
>> +
>>   class CameraSensorHelperImx477 : public CameraSensorHelper
>>   {
>>   public:
>> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp
>> index 4eabbbda..895bf967 100644
>> --- a/src/libcamera/sensor/camera_sensor_properties.cpp
>> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp
>> @@ -115,6 +115,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>>   			.unitCellSize = { 2900, 2900 },
>>   			.testPatternModes = {},
>>   		} },
>> +		{ "imx335", {
>> +			.unitCellSize = { 2000, 2000 },
>> +			.testPatternModes = {},
>> +		} },
>>   		{ "imx477", {
>>   			.unitCellSize = { 1550, 1550 },
>>   			.testPatternModes = {},
>> --
>> 2.44.0
>>