[PATCH 3/4] apps: qcam: Use standard key sequence for quit action

Stefan Klug stefan.klug at ideasonboard.com
Fri May 3 16:43:41 CEST 2024


Hi Laurent,

thanks for the patch.

On Fri, May 03, 2024 at 05:52:04AM +0300, Laurent Pinchart wrote:
> Replace the manual CTRL+Q key sequence with QKeySequence::Quit. This
> automatically maps to the native shortcut for the quit action,
> regardless of the platform. Even though we don't expect qcam to run on
> non-Linux platform, using a QKeySequence is still a good practice when
> one exists.
> 
> This doesn't change qcam's behaviour, as the native quit key sequence is
> CTRL+Q on Linux systems.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Stefan Klug <stefan.klug at ideasonboard.com> 

Cheers,
Stefan

> ---
>  src/apps/qcam/main_window.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp
> index 0f16c038d516..361d582532d5 100644
> --- a/src/apps/qcam/main_window.cpp
> +++ b/src/apps/qcam/main_window.cpp
> @@ -190,7 +190,7 @@ int MainWindow::createToolbars()
>  	action = toolbar_->addAction(QIcon::fromTheme("application-exit",
>  						      QIcon(":x-circle.svg")),
>  				     "Quit");
> -	action->setShortcut(Qt::CTRL | Qt::Key_Q);
> +	action->setShortcut(QKeySequence::Quit);
>  	connect(action, &QAction::triggered, this, &MainWindow::quit);
>  
>  	/* Camera selector. */
> -- 
> Regards,
> 
> Laurent Pinchart
> 


More information about the libcamera-devel mailing list