[PATCH 1/2] fixup! ipa: libipa: Add AgcMeanLuminance base class
Kieran Bingham
kieran.bingham at ideasonboard.com
Wed May 8 13:52:49 CEST 2024
I will apply this series with the following fixup.
Fixes:
FAILED: src/ipa/libipa/libipa.a.p/agc_mean_luminance.cpp.o
clang++ -Isrc/ipa/libipa/libipa.a.p -Isrc/ipa/libipa -I../src/ipa/libipa -Iinclude -I../include -Iinclude/libcamera/ipa -Iinclude/libcamera -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c++17 -O0 -g -stdlib=libc++ -Wextra-semi -Wthread-safety -Wshadow -include /builds/camera/libcamera/build/config.h -Wno-c99-designator -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/libipa/libipa.a.p/agc_mean_luminance.cpp.o -MF src/ipa/libipa/libipa.a.p/agc_mean_luminance.cpp.o.d -o src/ipa/libipa/libipa.a.p/agc_mean_luminance.cpp.o -c ../src/ipa/libipa/agc_mean_luminance.cpp
In file included from ../src/ipa/libipa/agc_mean_luminance.cpp:8:
../src/ipa/libipa/agc_mean_luminance.h:94:2: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
}; /* namespace ipa */
^
../src/ipa/libipa/agc_mean_luminance.h:96:2: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
}; /* namespace libcamera */
^
../src/ipa/libipa/agc_mean_luminance.cpp:575:2: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
}; /* namespace ipa */
^
../src/ipa/libipa/agc_mean_luminance.cpp:577:2: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
}; /* namespace libcamera */
^
4 errors generated.
Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
src/ipa/libipa/agc_mean_luminance.cpp | 4 ++--
src/ipa/libipa/agc_mean_luminance.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp
index 004d84d8c5d8..2bf84d05b6dd 100644
--- a/src/ipa/libipa/agc_mean_luminance.cpp
+++ b/src/ipa/libipa/agc_mean_luminance.cpp
@@ -572,6 +572,6 @@ AgcMeanLuminance::calculateNewEv(uint32_t constraintModeIndex,
* their configure() function.
*/
-}; /* namespace ipa */
+} /* namespace ipa */
-}; /* namespace libcamera */
+} /* namespace libcamera */
diff --git a/src/ipa/libipa/agc_mean_luminance.h b/src/ipa/libipa/agc_mean_luminance.h
index ef8ba28fd6ab..0a81c6d285b8 100644
--- a/src/ipa/libipa/agc_mean_luminance.h
+++ b/src/ipa/libipa/agc_mean_luminance.h
@@ -91,6 +91,6 @@ private:
ControlInfoMap::Map controls_;
};
-}; /* namespace ipa */
+} /* namespace ipa */
-}; /* namespace libcamera */
+} /* namespace libcamera */
--
2.34.1
More information about the libcamera-devel
mailing list