[PATCH] libcamera: Drop file name from header comment blocks
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Wed May 8 21:40:15 CEST 2024
Hi Dan,
On Wed, May 08, 2024 at 08:08:19PM +0100, Daniel Scally wrote:
> On 08/05/2024 17:34, Laurent Pinchart wrote:
> > Source files in libcamera start by a comment block header, which
> > includes the file name and a one-line description of the file contents.
> > While the latter is useful to get a quick overview of the file contents
> > at a glance, the former is mostly a source of inconvenience. The name in
> > the comments can easily get out of sync with the file name when files
> > are renamed, and copy & paste during development have often lead to
> > incorrect names being used to start with.
> >
> > Readers of the source code are expected to know which file they're
> > looking it. Drop the file name from the header comment block.
> >
> > The change was generated with the following script:
> >
> > ----------------------------------------
> >
> > dirs="include/libcamera src test utils"
> >
> > declare -rA patterns=(
> > ['c']=' \* '
> > ['cpp']=' \* '
> > ['h']=' \* '
> > ['py']='# '
> > ['sh']='# '
> > )
> >
> > for ext in ${!patterns[@]} ; do
> > files=$(for dir in $dirs ; do find $dir -name "*.${ext}" ; done)
> > pattern=${patterns[${ext}]}
> >
> > for file in $files ; do
> > name=$(basename ${file})
> > sed -i "s/^\(${pattern}\)${name} - /\1/" "$file"
> > done
> > done
> > ----------------------------------------
>
> This misses the broken ones where the filename is already out of sync with the comment, and the
> templates for code-generation:
>
> $ egrep --exclude-dir=patches/ -Iir "\* [a-z _]*\.(cpp|h) -"
> utils/ipc/generators/libcamera_templates/core_ipa_interface.h.tmpl: * core_ipa_interface.h -
> libcamera core definitions for Image Processing Algorithms
> utils/ipc/generators/libcamera_templates/core_ipa_serializer.h.tmpl: * core_ipa_serializer.h - Data
> serializer for core libcamera definitions for IPA
> utils/gen-header.sh: * libcamera.h - libcamera public API
> test/byte-stream-buffer.cpp: * byte_stream_buffer.cpp - ByteStreamBuffer tests
> test/shared-fd.cpp: * shared_fd.cpp - SharedFD test
> test/log/log_api.cpp: * log.cpp - log API test
> test/gstreamer/gstreamer_test.h: * gstreamer_test.cpp - GStreamer test base class
> test/gstreamer/gstreamer_device_provider_test.cpp: * gstreamer_single_stream_test.cpp - GStreamer
> single stream capture test
> test/bayer-format.cpp: * bayer_format.cpp - BayerFormat class tests
> test/object-delete.cpp: * object.cpp - Object deletion tests
> test/controls/control_info_map.cpp: * control_info.cpp - ControlInfoMap tests
> src/ipa/ipu3/algorithms/blc.h: * black_correction.h - IPU3 Black Level Correction control
> src/ipa/rpi/vc4/vc4.cpp: * rpi.cpp - Raspberry Pi VC4/BCM2835 ISP IPA.
> src/ipa/rpi/controller/tonemap_status.h: * hdr.h - Tonemap control algorithm status
> src/ipa/rpi/controller/denoise_algorithm.h: * denoise.h - Denoise control algorithm interface
> src/ipa/rpi/controller/rpi/denoise.cpp: * Denoise.cpp - Denoise (spatial, colour, temporal) control
> algorithm
> src/apps/ipa-verify/main.cpp: * ipa_verify.cpp - Verify signature on an IPA module
> src/apps/qcam/viewfinder_gl.cpp: * viewfinderGL.cpp - OpenGL Viewfinder for rendering by OpenGL shader
> src/apps/qcam/format_converter.cpp: * format_convert.cpp - qcam - Convert buffer to RGB
> src/apps/qcam/message_handler.h: * message_handler.cpp - qcam - Log message handling
> src/apps/qcam/format_converter.h: * format_convert.h - qcam - Convert buffer to RGB
> src/apps/qcam/viewfinder_gl.h: * viewfinder_GL.h - OpenGL Viewfinder for rendering by OpenGL shader
> src/apps/cam/sdl_sink.cpp: * sdl_sink.h - SDL Sink
> src/apps/lc-compliance/helpers/capture.cpp: * simple_capture.cpp - Simple capture helper
> src/apps/lc-compliance/helpers/capture.h: * simple_capture.h - Simple capture helper
> src/libcamera/base/backtrace.cpp: * backtrace.h - Call stack backtraces
> src/libcamera/camera_manager.cpp: * camera_manager.h - Camera management
> src/libcamera/delayed_controls.cpp: * delayed_controls.h - Helper to deal with controls that take
> effect with a delay
> src/libcamera/ipa_pub_key.cpp.in: * ipa_pub_key.cpp - IPA module signing public key
> src/libcamera/version.cpp.in: * version.cpp - libcamera version
> src/android/camera_ops.cpp: * camera_ops.h - Android Camera HAL Operations
> src/android/mm/generic_frame_buffer_allocator.cpp: * generic_camera_buffer.cpp - Allocate
> FrameBuffer using gralloc API
> src/android/mm/cros_frame_buffer_allocator.cpp: * cros_frame_buffer.cpp - Allocate FrameBuffer for
> Chromium OS using
> include/libcamera/version.h.in: * version.h - Library version information
> include/libcamera/formats.h.in: * formats.h - Formats
> include/libcamera/internal/tracepoints.h.in: * tracepoints.h - Tracepoints with lttng
> include/libcamera/base/thread_annotations.h: * thread_annotation.h - Macro of Clang thread safety
> analysis
> include/libcamera/control_ids.h.in: * control_ids.h - Control ID list
> include/libcamera/property_ids.h.in: * property_ids.h - Property ID list
Wow, that's a lot !
> Otherwise, looks good to me:
>
> Reviewed-by: Daniel Scally <dan.scally at ideasonboard.com>
I'll push this patch with this additional sentence added to the commit
message:
This misses several files that are out of sync with the comment block
header. Those will be addressed separately and manually.
and I will send a separate patch to address the remaining files.
> > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > ---
> > include/libcamera/base/backtrace.h | 2 +-
> > include/libcamera/base/bound_method.h | 2 +-
> > include/libcamera/base/class.h | 2 +-
> > include/libcamera/base/compiler.h | 2 +-
> > include/libcamera/base/event_dispatcher.h | 2 +-
> > include/libcamera/base/event_dispatcher_poll.h | 2 +-
> > include/libcamera/base/event_notifier.h | 2 +-
> > include/libcamera/base/file.h | 2 +-
> > include/libcamera/base/flags.h | 2 +-
> > include/libcamera/base/log.h | 2 +-
> > include/libcamera/base/message.h | 2 +-
> > include/libcamera/base/mutex.h | 2 +-
> > include/libcamera/base/object.h | 2 +-
> > include/libcamera/base/private.h | 2 +-
> > include/libcamera/base/semaphore.h | 2 +-
> > include/libcamera/base/shared_fd.h | 2 +-
> > include/libcamera/base/signal.h | 2 +-
> > include/libcamera/base/span.h | 2 +-
> > include/libcamera/base/thread.h | 2 +-
> > include/libcamera/base/timer.h | 2 +-
> > include/libcamera/base/unique_fd.h | 2 +-
> > include/libcamera/base/utils.h | 2 +-
> > include/libcamera/camera.h | 2 +-
> > include/libcamera/camera_manager.h | 2 +-
> > include/libcamera/color_space.h | 2 +-
> > include/libcamera/controls.h | 2 +-
> > include/libcamera/framebuffer.h | 2 +-
> > include/libcamera/framebuffer_allocator.h | 2 +-
> > include/libcamera/geometry.h | 2 +-
> > include/libcamera/internal/bayer_format.h | 2 +-
> > include/libcamera/internal/byte_stream_buffer.h | 2 +-
> > include/libcamera/internal/camera.h | 2 +-
> > include/libcamera/internal/camera_controls.h | 2 +-
> > include/libcamera/internal/camera_lens.h | 2 +-
> > include/libcamera/internal/camera_manager.h | 2 +-
> > include/libcamera/internal/camera_sensor.h | 2 +-
> > include/libcamera/internal/camera_sensor_properties.h | 2 +-
> > include/libcamera/internal/control_serializer.h | 2 +-
> > include/libcamera/internal/control_validator.h | 2 +-
> > include/libcamera/internal/converter.h | 2 +-
> > include/libcamera/internal/converter/converter_v4l2_m2m.h | 2 +-
> > include/libcamera/internal/delayed_controls.h | 2 +-
> > include/libcamera/internal/device_enumerator.h | 2 +-
> > include/libcamera/internal/device_enumerator_sysfs.h | 2 +-
> > include/libcamera/internal/device_enumerator_udev.h | 2 +-
> > include/libcamera/internal/dma_heaps.h | 2 +-
> > include/libcamera/internal/formats.h | 2 +-
> > include/libcamera/internal/framebuffer.h | 2 +-
> > include/libcamera/internal/ipa_data_serializer.h | 2 +-
> > include/libcamera/internal/ipa_manager.h | 2 +-
> > include/libcamera/internal/ipa_module.h | 2 +-
> > include/libcamera/internal/ipa_proxy.h | 2 +-
> > include/libcamera/internal/ipc_pipe.h | 2 +-
> > include/libcamera/internal/ipc_pipe_unixsocket.h | 2 +-
> > include/libcamera/internal/ipc_unixsocket.h | 2 +-
> > include/libcamera/internal/mapped_framebuffer.h | 2 +-
> > include/libcamera/internal/media_device.h | 2 +-
> > include/libcamera/internal/media_object.h | 2 +-
> > include/libcamera/internal/pipeline_handler.h | 2 +-
> > include/libcamera/internal/process.h | 2 +-
> > include/libcamera/internal/pub_key.h | 2 +-
> > include/libcamera/internal/request.h | 2 +-
> > include/libcamera/internal/shared_mem_object.h | 2 +-
> > include/libcamera/internal/software_isp/debayer_params.h | 2 +-
> > include/libcamera/internal/software_isp/software_isp.h | 2 +-
> > include/libcamera/internal/software_isp/swisp_stats.h | 2 +-
> > include/libcamera/internal/source_paths.h | 2 +-
> > include/libcamera/internal/sysfs.h | 2 +-
> > include/libcamera/internal/v4l2_device.h | 2 +-
> > include/libcamera/internal/v4l2_pixelformat.h | 2 +-
> > include/libcamera/internal/v4l2_subdevice.h | 2 +-
> > include/libcamera/internal/v4l2_videodevice.h | 2 +-
> > include/libcamera/internal/yaml_parser.h | 2 +-
> > include/libcamera/ipa/ipa_controls.h | 2 +-
> > include/libcamera/ipa/ipa_interface.h | 2 +-
> > include/libcamera/ipa/ipa_module_info.h | 2 +-
> > include/libcamera/logging.h | 2 +-
> > include/libcamera/orientation.h | 2 +-
> > include/libcamera/pixel_format.h | 2 +-
> > include/libcamera/request.h | 2 +-
> > include/libcamera/stream.h | 2 +-
> > include/libcamera/transform.h | 2 +-
> > src/android/camera3_hal.cpp | 2 +-
> > src/android/camera_buffer.h | 2 +-
> > src/android/camera_capabilities.cpp | 2 +-
> > src/android/camera_capabilities.h | 2 +-
> > src/android/camera_device.cpp | 2 +-
> > src/android/camera_device.h | 2 +-
> > src/android/camera_hal_config.cpp | 2 +-
> > src/android/camera_hal_config.h | 2 +-
> > src/android/camera_hal_manager.cpp | 2 +-
> > src/android/camera_hal_manager.h | 2 +-
> > src/android/camera_metadata.cpp | 2 +-
> > src/android/camera_metadata.h | 2 +-
> > src/android/camera_ops.h | 2 +-
> > src/android/camera_request.cpp | 2 +-
> > src/android/camera_request.h | 2 +-
> > src/android/camera_stream.cpp | 2 +-
> > src/android/camera_stream.h | 2 +-
> > src/android/cros/camera3_hal.cpp | 2 +-
> > src/android/cros_mojo_token.h | 2 +-
> > src/android/frame_buffer_allocator.h | 2 +-
> > src/android/hal_framebuffer.cpp | 2 +-
> > src/android/hal_framebuffer.h | 2 +-
> > src/android/jpeg/encoder.h | 2 +-
> > src/android/jpeg/encoder_jea.cpp | 2 +-
> > src/android/jpeg/encoder_jea.h | 2 +-
> > src/android/jpeg/encoder_libjpeg.cpp | 2 +-
> > src/android/jpeg/encoder_libjpeg.h | 2 +-
> > src/android/jpeg/exif.cpp | 2 +-
> > src/android/jpeg/exif.h | 2 +-
> > src/android/jpeg/post_processor_jpeg.cpp | 2 +-
> > src/android/jpeg/post_processor_jpeg.h | 2 +-
> > src/android/jpeg/thumbnailer.cpp | 2 +-
> > src/android/jpeg/thumbnailer.h | 2 +-
> > src/android/mm/cros_camera_buffer.cpp | 2 +-
> > src/android/mm/generic_camera_buffer.cpp | 2 +-
> > src/android/mm/libhardware_stub.c | 2 +-
> > src/android/post_processor.h | 2 +-
> > src/android/yuv/post_processor_yuv.cpp | 2 +-
> > src/android/yuv/post_processor_yuv.h | 2 +-
> > src/apps/cam/camera_session.cpp | 2 +-
> > src/apps/cam/camera_session.h | 2 +-
> > src/apps/cam/capture_script.cpp | 2 +-
> > src/apps/cam/capture_script.h | 2 +-
> > src/apps/cam/drm.cpp | 2 +-
> > src/apps/cam/drm.h | 2 +-
> > src/apps/cam/file_sink.cpp | 2 +-
> > src/apps/cam/file_sink.h | 2 +-
> > src/apps/cam/frame_sink.cpp | 2 +-
> > src/apps/cam/frame_sink.h | 2 +-
> > src/apps/cam/kms_sink.cpp | 2 +-
> > src/apps/cam/kms_sink.h | 2 +-
> > src/apps/cam/main.cpp | 2 +-
> > src/apps/cam/main.h | 2 +-
> > src/apps/cam/sdl_sink.h | 2 +-
> > src/apps/cam/sdl_texture.cpp | 2 +-
> > src/apps/cam/sdl_texture.h | 2 +-
> > src/apps/cam/sdl_texture_mjpg.cpp | 2 +-
> > src/apps/cam/sdl_texture_mjpg.h | 2 +-
> > src/apps/cam/sdl_texture_yuv.cpp | 2 +-
> > src/apps/cam/sdl_texture_yuv.h | 2 +-
> > src/apps/common/dng_writer.cpp | 2 +-
> > src/apps/common/dng_writer.h | 2 +-
> > src/apps/common/event_loop.cpp | 2 +-
> > src/apps/common/event_loop.h | 2 +-
> > src/apps/common/image.cpp | 2 +-
> > src/apps/common/image.h | 2 +-
> > src/apps/common/options.cpp | 2 +-
> > src/apps/common/options.h | 2 +-
> > src/apps/common/ppm_writer.cpp | 2 +-
> > src/apps/common/ppm_writer.h | 2 +-
> > src/apps/common/stream_options.cpp | 2 +-
> > src/apps/common/stream_options.h | 2 +-
> > src/apps/lc-compliance/environment.cpp | 2 +-
> > src/apps/lc-compliance/environment.h | 2 +-
> > src/apps/lc-compliance/main.cpp | 2 +-
> > src/apps/lc-compliance/tests/capture_test.cpp | 2 +-
> > src/apps/qcam/cam_select_dialog.cpp | 2 +-
> > src/apps/qcam/cam_select_dialog.h | 2 +-
> > src/apps/qcam/main.cpp | 2 +-
> > src/apps/qcam/main_window.cpp | 2 +-
> > src/apps/qcam/main_window.h | 2 +-
> > src/apps/qcam/message_handler.cpp | 2 +-
> > src/apps/qcam/viewfinder.h | 2 +-
> > src/apps/qcam/viewfinder_qt.cpp | 2 +-
> > src/apps/qcam/viewfinder_qt.h | 2 +-
> > src/gstreamer/gstlibcamera-utils.h | 2 +-
> > src/gstreamer/gstlibcameraallocator.cpp | 2 +-
> > src/gstreamer/gstlibcameraallocator.h | 2 +-
> > src/gstreamer/gstlibcamerapad.cpp | 2 +-
> > src/gstreamer/gstlibcamerapad.h | 2 +-
> > src/gstreamer/gstlibcamerapool.cpp | 2 +-
> > src/gstreamer/gstlibcamerapool.h | 2 +-
> > src/gstreamer/gstlibcameraprovider.h | 2 +-
> > src/gstreamer/gstlibcamerasrc.cpp | 2 +-
> > src/gstreamer/gstlibcamerasrc.h | 2 +-
> > src/ipa/ipa-sign-install.sh | 2 +-
> > src/ipa/ipa-sign.sh | 2 +-
> > src/ipa/ipu3/algorithms/af.cpp | 2 +-
> > src/ipa/ipu3/algorithms/af.h | 2 +-
> > src/ipa/ipu3/algorithms/agc.h | 2 +-
> > src/ipa/ipu3/algorithms/algorithm.h | 2 +-
> > src/ipa/ipu3/algorithms/awb.cpp | 2 +-
> > src/ipa/ipu3/algorithms/awb.h | 2 +-
> > src/ipa/ipu3/algorithms/blc.cpp | 2 +-
> > src/ipa/ipu3/algorithms/tone_mapping.cpp | 2 +-
> > src/ipa/ipu3/algorithms/tone_mapping.h | 2 +-
> > src/ipa/ipu3/ipa_context.cpp | 2 +-
> > src/ipa/ipu3/ipa_context.h | 2 +-
> > src/ipa/ipu3/ipu3.cpp | 2 +-
> > src/ipa/ipu3/module.h | 2 +-
> > src/ipa/libipa/agc_mean_luminance.cpp | 2 +-
> > src/ipa/libipa/algorithm.cpp | 2 +-
> > src/ipa/libipa/algorithm.h | 2 +-
> > src/ipa/libipa/camera_sensor_helper.cpp | 2 +-
> > src/ipa/libipa/camera_sensor_helper.h | 2 +-
> > src/ipa/libipa/exposure_mode_helper.cpp | 2 +-
> > src/ipa/libipa/exposure_mode_helper.h | 2 +-
> > src/ipa/libipa/fc_queue.cpp | 2 +-
> > src/ipa/libipa/fc_queue.h | 2 +-
> > src/ipa/libipa/histogram.cpp | 2 +-
> > src/ipa/libipa/histogram.h | 2 +-
> > src/ipa/libipa/module.cpp | 2 +-
> > src/ipa/libipa/module.h | 2 +-
> > src/ipa/rkisp1/algorithms/agc.cpp | 2 +-
> > src/ipa/rkisp1/algorithms/agc.h | 2 +-
> > src/ipa/rkisp1/algorithms/algorithm.h | 2 +-
> > src/ipa/rkisp1/algorithms/awb.cpp | 2 +-
> > src/ipa/rkisp1/algorithms/awb.h | 2 +-
> > src/ipa/rkisp1/algorithms/blc.cpp | 2 +-
> > src/ipa/rkisp1/algorithms/blc.h | 2 +-
> > src/ipa/rkisp1/algorithms/cproc.cpp | 2 +-
> > src/ipa/rkisp1/algorithms/cproc.h | 2 +-
> > src/ipa/rkisp1/algorithms/dpcc.cpp | 2 +-
> > src/ipa/rkisp1/algorithms/dpcc.h | 2 +-
> > src/ipa/rkisp1/algorithms/dpf.cpp | 2 +-
> > src/ipa/rkisp1/algorithms/dpf.h | 2 +-
> > src/ipa/rkisp1/algorithms/filter.cpp | 2 +-
> > src/ipa/rkisp1/algorithms/filter.h | 2 +-
> > src/ipa/rkisp1/algorithms/gsl.cpp | 2 +-
> > src/ipa/rkisp1/algorithms/gsl.h | 2 +-
> > src/ipa/rkisp1/algorithms/lsc.cpp | 2 +-
> > src/ipa/rkisp1/algorithms/lsc.h | 2 +-
> > src/ipa/rkisp1/ipa_context.cpp | 2 +-
> > src/ipa/rkisp1/ipa_context.h | 2 +-
> > src/ipa/rkisp1/module.h | 2 +-
> > src/ipa/rkisp1/rkisp1.cpp | 2 +-
> > src/ipa/rpi/cam_helper/cam_helper.cpp | 2 +-
> > src/ipa/rpi/cam_helper/cam_helper.h | 2 +-
> > src/ipa/rpi/cam_helper/cam_helper_imx219.cpp | 2 +-
> > src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 2 +-
> > src/ipa/rpi/cam_helper/cam_helper_imx296.cpp | 2 +-
> > src/ipa/rpi/cam_helper/cam_helper_imx477.cpp | 2 +-
> > src/ipa/rpi/cam_helper/cam_helper_imx519.cpp | 2 +-
> > src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 2 +-
> > src/ipa/rpi/cam_helper/cam_helper_ov5647.cpp | 2 +-
> > src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp | 2 +-
> > src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp | 2 +-
> > src/ipa/rpi/cam_helper/md_parser.h | 2 +-
> > src/ipa/rpi/cam_helper/md_parser_smia.cpp | 2 +-
> > src/ipa/rpi/common/ipa_base.cpp | 2 +-
> > src/ipa/rpi/common/ipa_base.h | 2 +-
> > src/ipa/rpi/controller/af_status.h | 2 +-
> > src/ipa/rpi/controller/agc_algorithm.h | 2 +-
> > src/ipa/rpi/controller/agc_status.h | 2 +-
> > src/ipa/rpi/controller/algorithm.cpp | 2 +-
> > src/ipa/rpi/controller/algorithm.h | 2 +-
> > src/ipa/rpi/controller/alsc_status.h | 2 +-
> > src/ipa/rpi/controller/awb_algorithm.h | 2 +-
> > src/ipa/rpi/controller/awb_status.h | 2 +-
> > src/ipa/rpi/controller/black_level_algorithm.h | 2 +-
> > src/ipa/rpi/controller/black_level_status.h | 2 +-
> > src/ipa/rpi/controller/camera_mode.h | 2 +-
> > src/ipa/rpi/controller/ccm_algorithm.h | 2 +-
> > src/ipa/rpi/controller/ccm_status.h | 2 +-
> > src/ipa/rpi/controller/contrast_algorithm.h | 2 +-
> > src/ipa/rpi/controller/contrast_status.h | 2 +-
> > src/ipa/rpi/controller/controller.cpp | 2 +-
> > src/ipa/rpi/controller/controller.h | 2 +-
> > src/ipa/rpi/controller/denoise_status.h | 2 +-
> > src/ipa/rpi/controller/device_status.cpp | 2 +-
> > src/ipa/rpi/controller/device_status.h | 2 +-
> > src/ipa/rpi/controller/dpc_status.h | 2 +-
> > src/ipa/rpi/controller/geq_status.h | 2 +-
> > src/ipa/rpi/controller/hdr_algorithm.h | 2 +-
> > src/ipa/rpi/controller/hdr_status.h | 2 +-
> > src/ipa/rpi/controller/histogram.cpp | 2 +-
> > src/ipa/rpi/controller/histogram.h | 2 +-
> > src/ipa/rpi/controller/lux_status.h | 2 +-
> > src/ipa/rpi/controller/metadata.h | 2 +-
> > src/ipa/rpi/controller/noise_status.h | 2 +-
> > src/ipa/rpi/controller/pdaf_data.h | 2 +-
> > src/ipa/rpi/controller/pwl.cpp | 2 +-
> > src/ipa/rpi/controller/pwl.h | 2 +-
> > src/ipa/rpi/controller/region_stats.h | 2 +-
> > src/ipa/rpi/controller/rpi/af.cpp | 2 +-
> > src/ipa/rpi/controller/rpi/af.h | 2 +-
> > src/ipa/rpi/controller/rpi/agc.cpp | 2 +-
> > src/ipa/rpi/controller/rpi/agc.h | 2 +-
> > src/ipa/rpi/controller/rpi/agc_channel.cpp | 2 +-
> > src/ipa/rpi/controller/rpi/agc_channel.h | 2 +-
> > src/ipa/rpi/controller/rpi/alsc.cpp | 2 +-
> > src/ipa/rpi/controller/rpi/alsc.h | 2 +-
> > src/ipa/rpi/controller/rpi/awb.cpp | 2 +-
> > src/ipa/rpi/controller/rpi/awb.h | 2 +-
> > src/ipa/rpi/controller/rpi/black_level.cpp | 2 +-
> > src/ipa/rpi/controller/rpi/black_level.h | 2 +-
> > src/ipa/rpi/controller/rpi/cac.cpp | 2 +-
> > src/ipa/rpi/controller/rpi/ccm.cpp | 2 +-
> > src/ipa/rpi/controller/rpi/ccm.h | 2 +-
> > src/ipa/rpi/controller/rpi/contrast.cpp | 2 +-
> > src/ipa/rpi/controller/rpi/contrast.h | 2 +-
> > src/ipa/rpi/controller/rpi/dpc.cpp | 2 +-
> > src/ipa/rpi/controller/rpi/dpc.h | 2 +-
> > src/ipa/rpi/controller/rpi/focus.h | 2 +-
> > src/ipa/rpi/controller/rpi/geq.cpp | 2 +-
> > src/ipa/rpi/controller/rpi/geq.h | 2 +-
> > src/ipa/rpi/controller/rpi/hdr.cpp | 2 +-
> > src/ipa/rpi/controller/rpi/hdr.h | 2 +-
> > src/ipa/rpi/controller/rpi/lux.cpp | 2 +-
> > src/ipa/rpi/controller/rpi/lux.h | 2 +-
> > src/ipa/rpi/controller/rpi/noise.cpp | 2 +-
> > src/ipa/rpi/controller/rpi/noise.h | 2 +-
> > src/ipa/rpi/controller/rpi/saturation.cpp | 2 +-
> > src/ipa/rpi/controller/rpi/sdn.cpp | 2 +-
> > src/ipa/rpi/controller/rpi/sdn.h | 2 +-
> > src/ipa/rpi/controller/rpi/sharpen.cpp | 2 +-
> > src/ipa/rpi/controller/rpi/sharpen.h | 2 +-
> > src/ipa/rpi/controller/rpi/tonemap.cpp | 2 +-
> > src/ipa/rpi/controller/saturation_status.h | 2 +-
> > src/ipa/rpi/controller/sharpen_algorithm.h | 2 +-
> > src/ipa/rpi/controller/sharpen_status.h | 2 +-
> > src/ipa/rpi/controller/statistics.h | 2 +-
> > src/ipa/rpi/controller/stitch_status.h | 2 +-
> > src/ipa/simple/black_level.cpp | 2 +-
> > src/ipa/simple/black_level.h | 2 +-
> > src/ipa/simple/soft_simple.cpp | 2 +-
> > src/ipa/vimc/vimc.cpp | 2 +-
> > src/libcamera/base/bound_method.cpp | 2 +-
> > src/libcamera/base/class.cpp | 2 +-
> > src/libcamera/base/event_dispatcher.cpp | 2 +-
> > src/libcamera/base/event_dispatcher_poll.cpp | 2 +-
> > src/libcamera/base/event_notifier.cpp | 2 +-
> > src/libcamera/base/file.cpp | 2 +-
> > src/libcamera/base/flags.cpp | 2 +-
> > src/libcamera/base/log.cpp | 2 +-
> > src/libcamera/base/message.cpp | 2 +-
> > src/libcamera/base/mutex.cpp | 2 +-
> > src/libcamera/base/object.cpp | 2 +-
> > src/libcamera/base/semaphore.cpp | 2 +-
> > src/libcamera/base/shared_fd.cpp | 2 +-
> > src/libcamera/base/signal.cpp | 2 +-
> > src/libcamera/base/thread.cpp | 2 +-
> > src/libcamera/base/timer.cpp | 2 +-
> > src/libcamera/base/unique_fd.cpp | 2 +-
> > src/libcamera/base/utils.cpp | 2 +-
> > src/libcamera/bayer_format.cpp | 2 +-
> > src/libcamera/byte_stream_buffer.cpp | 2 +-
> > src/libcamera/camera.cpp | 2 +-
> > src/libcamera/camera_controls.cpp | 2 +-
> > src/libcamera/camera_lens.cpp | 2 +-
> > src/libcamera/color_space.cpp | 2 +-
> > src/libcamera/control_serializer.cpp | 2 +-
> > src/libcamera/control_validator.cpp | 2 +-
> > src/libcamera/controls.cpp | 2 +-
> > src/libcamera/converter.cpp | 2 +-
> > src/libcamera/converter/converter_v4l2_m2m.cpp | 2 +-
> > src/libcamera/device_enumerator.cpp | 2 +-
> > src/libcamera/device_enumerator_sysfs.cpp | 2 +-
> > src/libcamera/device_enumerator_udev.cpp | 2 +-
> > src/libcamera/dma_heaps.cpp | 2 +-
> > src/libcamera/fence.cpp | 2 +-
> > src/libcamera/formats.cpp | 2 +-
> > src/libcamera/framebuffer.cpp | 2 +-
> > src/libcamera/framebuffer_allocator.cpp | 2 +-
> > src/libcamera/geometry.cpp | 2 +-
> > src/libcamera/ipa_controls.cpp | 2 +-
> > src/libcamera/ipa_data_serializer.cpp | 2 +-
> > src/libcamera/ipa_interface.cpp | 2 +-
> > src/libcamera/ipa_manager.cpp | 2 +-
> > src/libcamera/ipa_module.cpp | 2 +-
> > src/libcamera/ipa_proxy.cpp | 2 +-
> > src/libcamera/ipc_pipe.cpp | 2 +-
> > src/libcamera/ipc_pipe_unixsocket.cpp | 2 +-
> > src/libcamera/ipc_unixsocket.cpp | 2 +-
> > src/libcamera/mapped_framebuffer.cpp | 2 +-
> > src/libcamera/media_device.cpp | 2 +-
> > src/libcamera/media_object.cpp | 2 +-
> > src/libcamera/orientation.cpp | 2 +-
> > src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 2 +-
> > src/libcamera/pipeline/ipu3/cio2.cpp | 2 +-
> > src/libcamera/pipeline/ipu3/cio2.h | 2 +-
> > src/libcamera/pipeline/ipu3/frames.cpp | 2 +-
> > src/libcamera/pipeline/ipu3/frames.h | 2 +-
> > src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-
> > src/libcamera/pipeline/ipu3/imgu.h | 2 +-
> > src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-
> > src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-
> > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-
> > src/libcamera/pipeline/rpi/common/delayed_controls.cpp | 2 +-
> > src/libcamera/pipeline/rpi/common/delayed_controls.h | 2 +-
> > src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 2 +-
> > src/libcamera/pipeline/rpi/common/pipeline_base.h | 2 +-
> > src/libcamera/pipeline/rpi/common/rpi_stream.cpp | 2 +-
> > src/libcamera/pipeline/rpi/common/rpi_stream.h | 2 +-
> > src/libcamera/pipeline/rpi/vc4/vc4.cpp | 2 +-
> > src/libcamera/pipeline/simple/simple.cpp | 2 +-
> > src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 2 +-
> > src/libcamera/pipeline/vimc/vimc.cpp | 2 +-
> > src/libcamera/pipeline_handler.cpp | 2 +-
> > src/libcamera/pixel_format.cpp | 2 +-
> > src/libcamera/process.cpp | 2 +-
> > src/libcamera/pub_key.cpp | 2 +-
> > src/libcamera/request.cpp | 2 +-
> > src/libcamera/sensor/camera_sensor.cpp | 2 +-
> > src/libcamera/sensor/camera_sensor_properties.cpp | 2 +-
> > src/libcamera/shared_mem_object.cpp | 2 +-
> > src/libcamera/software_isp/debayer.cpp | 2 +-
> > src/libcamera/software_isp/debayer.h | 2 +-
> > src/libcamera/software_isp/debayer_cpu.cpp | 2 +-
> > src/libcamera/software_isp/debayer_cpu.h | 2 +-
> > src/libcamera/software_isp/software_isp.cpp | 2 +-
> > src/libcamera/software_isp/swstats_cpu.cpp | 2 +-
> > src/libcamera/software_isp/swstats_cpu.h | 2 +-
> > src/libcamera/source_paths.cpp | 2 +-
> > src/libcamera/stream.cpp | 2 +-
> > src/libcamera/sysfs.cpp | 2 +-
> > src/libcamera/tracepoints.cpp | 2 +-
> > src/libcamera/transform.cpp | 2 +-
> > src/libcamera/v4l2_device.cpp | 2 +-
> > src/libcamera/v4l2_pixelformat.cpp | 2 +-
> > src/libcamera/v4l2_subdevice.cpp | 2 +-
> > src/libcamera/v4l2_videodevice.cpp | 2 +-
> > src/libcamera/yaml_parser.cpp | 2 +-
> > src/v4l2/v4l2_camera.cpp | 2 +-
> > src/v4l2/v4l2_camera.h | 2 +-
> > src/v4l2/v4l2_camera_file.h | 2 +-
> > src/v4l2/v4l2_camera_proxy.cpp | 2 +-
> > src/v4l2/v4l2_camera_proxy.h | 2 +-
> > src/v4l2/v4l2_compat.cpp | 2 +-
> > src/v4l2/v4l2_compat_manager.cpp | 2 +-
> > src/v4l2/v4l2_compat_manager.h | 2 +-
> > test/camera-sensor.cpp | 2 +-
> > test/controls/control_info.cpp | 2 +-
> > test/controls/control_list.cpp | 2 +-
> > test/controls/control_value.cpp | 2 +-
> > test/delayed_controls.cpp | 2 +-
> > test/event-dispatcher.cpp | 2 +-
> > test/event-thread.cpp | 2 +-
> > test/event.cpp | 2 +-
> > test/fence.cpp | 2 +-
> > test/file.cpp | 2 +-
> > test/flags.cpp | 2 +-
> > test/geometry.cpp | 2 +-
> > test/gstreamer/gstreamer_multi_stream_test.cpp | 2 +-
> > test/gstreamer/gstreamer_single_stream_test.cpp | 2 +-
> > test/hotplug-cameras.cpp | 2 +-
> > test/ipa/ipa_interface_test.cpp | 2 +-
> > test/ipa/ipa_module_test.cpp | 2 +-
> > test/ipc/unixsocket.cpp | 2 +-
> > test/ipc/unixsocket_ipc.cpp | 2 +-
> > test/libtest/buffer_source.h | 2 +-
> > test/libtest/camera_test.h | 2 +-
> > test/libtest/test.cpp | 2 +-
> > test/libtest/test.h | 2 +-
> > test/log/log_process.cpp | 2 +-
> > test/media_device/media_device_link_test.cpp | 2 +-
> > test/media_device/media_device_print_test.cpp | 2 +-
> > test/media_device/media_device_test.cpp | 2 +-
> > test/media_device/media_device_test.h | 2 +-
> > test/message.cpp | 2 +-
> > test/object-invoke.cpp | 2 +-
> > test/object.cpp | 2 +-
> > test/process/process_test.cpp | 2 +-
> > test/public-api.cpp | 2 +-
> > test/serialization/control_serialization.cpp | 2 +-
> > .../generated_serializer/generated_serializer_test.cpp | 2 +-
> > test/serialization/ipa_data_serializer_test.cpp | 2 +-
> > test/serialization/serialization_test.cpp | 2 +-
> > test/serialization/serialization_test.h | 2 +-
> > test/signal-threads.cpp | 2 +-
> > test/signal.cpp | 2 +-
> > test/span.cpp | 2 +-
> > test/stream/stream_colorspace.cpp | 2 +-
> > test/stream/stream_formats.cpp | 2 +-
> > test/threads.cpp | 2 +-
> > test/timer-fail.cpp | 2 +-
> > test/timer-thread.cpp | 2 +-
> > test/timer.cpp | 2 +-
> > test/transform.cpp | 2 +-
> > test/unique-fd.cpp | 2 +-
> > test/utils.cpp | 2 +-
> > test/v4l2_compat/v4l2_compat_test.py | 2 +-
> > test/v4l2_subdevice/v4l2_subdevice_test.cpp | 2 +-
> > test/v4l2_subdevice/v4l2_subdevice_test.h | 2 +-
> > test/v4l2_videodevice/controls.cpp | 2 +-
> > test/yaml-parser.cpp | 2 +-
> > utils/checkstyle.py | 2 +-
> > utils/gen-controls.py | 2 +-
> > utils/gen-formats.py | 2 +-
> > utils/gen-ipa-priv-key.sh | 2 +-
> > utils/ipc/extract-docs.py | 2 +-
> > utils/ipc/generate.py | 2 +-
> > utils/ipc/generators/mojom_libcamera_generator.py | 2 +-
> > utils/ipc/parser.py | 2 +-
> > utils/ipu3/ipu3-capture.sh | 2 +-
> > utils/ipu3/ipu3-process.sh | 2 +-
> > utils/raspberrypi/ctt/alsc_only.py | 2 +-
> > utils/raspberrypi/ctt/colors.py | 2 +-
> > utils/raspberrypi/ctt/ctt.py | 2 +-
> > utils/raspberrypi/ctt/ctt_alsc.py | 2 +-
> > utils/raspberrypi/ctt/ctt_awb.py | 2 +-
> > utils/raspberrypi/ctt/ctt_ccm.py | 2 +-
> > utils/raspberrypi/ctt/ctt_geq.py | 2 +-
> > utils/raspberrypi/ctt/ctt_image_load.py | 2 +-
> > utils/raspberrypi/ctt/ctt_lux.py | 2 +-
> > utils/raspberrypi/ctt/ctt_macbeth_locator.py | 2 +-
> > utils/raspberrypi/ctt/ctt_noise.py | 2 +-
> > utils/raspberrypi/ctt/ctt_ransac.py | 2 +-
> > utils/raspberrypi/ctt/ctt_tools.py | 2 +-
> > utils/tracepoints/analyze-ipa-trace.py | 2 +-
> > utils/tracepoints/gen-tp-header.py | 2 +-
> > utils/tuning/libtuning/average.py | 2 +-
> > utils/tuning/libtuning/generators/generator.py | 2 +-
> > utils/tuning/libtuning/generators/raspberrypi_output.py | 2 +-
> > utils/tuning/libtuning/generators/yaml_output.py | 2 +-
> > utils/tuning/libtuning/gradient.py | 2 +-
> > utils/tuning/libtuning/image.py | 2 +-
> > utils/tuning/libtuning/libtuning.py | 2 +-
> > utils/tuning/libtuning/macbeth.py | 2 +-
> > utils/tuning/libtuning/modules/lsc/raspberrypi.py | 2 +-
> > utils/tuning/libtuning/modules/lsc/rkisp1.py | 2 +-
> > utils/tuning/libtuning/modules/module.py | 2 +-
> > utils/tuning/libtuning/parsers/parser.py | 2 +-
> > utils/tuning/libtuning/parsers/raspberrypi_parser.py | 2 +-
> > utils/tuning/libtuning/parsers/yaml_parser.py | 2 +-
> > utils/tuning/libtuning/smoothing.py | 2 +-
> > utils/tuning/libtuning/utils.py | 2 +-
> > utils/tuning/raspberrypi/alsc.py | 2 +-
> > utils/tuning/raspberrypi_alsc_only.py | 2 +-
> > utils/tuning/rkisp1.py | 2 +-
> > 522 files changed, 522 insertions(+), 522 deletions(-)
[snip]
> > base-commit: fdcd5d04ec6a3b3c98a46041762cdaf4bdb76190
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list