[PATCH v1 2/2] libcamera: Drop remaining file name from header comment blocks

Dan Scally dan.scally at ideasonboard.com
Wed May 8 23:06:14 CEST 2024


Hi Laurent

On 08/05/2024 21:59, Laurent Pinchart wrote:
> Source files in libcamera start by a comment block header, which
> includes the file name and a one-line description of the file contents.
> While the latter is useful to get a quick overview of the file contents
> at a glance, the former is mostly a source of inconvenience. The name in
> the comments can easily get out of sync with the file name when files
> are renamed, and copy & paste during development have often lead to
> incorrect names being used to start with.
>
> Readers of the source code are expected to know which file they're
> looking it. Drop the file name from the header comment blocks in all
> remaining locations that were not caught by the automated script as they
> are out of sync with the file name.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>


Reviewed-by: Daniel Scally <dan.scally at ideasonboard.com>


But one heads up below...

> ---
>   include/libcamera/base/thread_annotations.h       | 2 +-
>   include/libcamera/fence.h                         | 2 +-
>   src/android/camera_ops.cpp                        | 2 +-
>   src/android/mm/cros_frame_buffer_allocator.cpp    | 3 +--
>   src/android/mm/generic_frame_buffer_allocator.cpp | 2 +-
>   src/apps/cam/sdl_sink.cpp                         | 2 +-
>   src/apps/ipa-verify/main.cpp                      | 2 +-
>   src/apps/lc-compliance/helpers/capture.cpp        | 2 +-
>   src/apps/lc-compliance/helpers/capture.h          | 2 +-
>   src/apps/qcam/format_converter.cpp                | 2 +-
>   src/apps/qcam/format_converter.h                  | 2 +-
>   src/apps/qcam/message_handler.h                   | 2 +-
>   src/apps/qcam/viewfinder_gl.cpp                   | 2 +-
>   src/apps/qcam/viewfinder_gl.h                     | 3 +--
>   src/gstreamer/gstlibcamera-utils.cpp              | 2 +-
>   src/gstreamer/gstlibcamera.cpp                    | 2 +-
>   src/gstreamer/gstlibcameraprovider.cpp            | 2 +-
>   src/ipa/ipu3/algorithms/agc.cpp                   | 2 +-
>   src/ipa/ipu3/algorithms/blc.h                     | 2 +-
>   src/ipa/rpi/controller/denoise_algorithm.h        | 2 +-
>   src/ipa/rpi/controller/rpi/denoise.cpp            | 2 +-
>   src/ipa/rpi/controller/tonemap_status.h           | 2 +-
>   src/ipa/rpi/vc4/vc4.cpp                           | 2 +-
>   src/libcamera/base/backtrace.cpp                  | 2 +-
>   src/libcamera/camera_manager.cpp                  | 2 +-
>   src/libcamera/delayed_controls.cpp                | 2 +-
>   src/libcamera/pipeline/rkisp1/rkisp1_path.cpp     | 2 +-
>   src/libcamera/pipeline/rkisp1/rkisp1_path.h       | 2 +-
>   src/v4l2/v4l2_camera_file.cpp                     | 2 +-
>   test/bayer-format.cpp                             | 2 +-
>   test/byte-stream-buffer.cpp                       | 2 +-
>   test/controls/control_info_map.cpp                | 2 +-
>   test/gstreamer/gstreamer_device_provider_test.cpp | 2 +-
>   test/gstreamer/gstreamer_test.h                   | 2 +-
>   test/log/log_api.cpp                              | 2 +-
>   test/object-delete.cpp                            | 2 +-
>   test/shared-fd.cpp                                | 2 +-
>   test/v4l2_videodevice/v4l2_videodevice_test.h     | 2 +-
>   utils/gen-ipa-pub-key.py                          | 2 +-
>   utils/rkisp1/rkisp1-capture.sh                    | 3 +--
>   40 files changed, 40 insertions(+), 43 deletions(-)
>
> diff --git a/include/libcamera/base/thread_annotations.h b/include/libcamera/base/thread_annotations.h
> index 25b3c7b6cf92..81930f0873dc 100644
> --- a/include/libcamera/base/thread_annotations.h
> +++ b/include/libcamera/base/thread_annotations.h
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2021, Google Inc.
>    *
> - * thread_annotation.h - Macro of Clang thread safety analysis
> + * Macro of Clang thread safety analysis
>    */
>   
>   #pragma once
> diff --git a/include/libcamera/fence.h b/include/libcamera/fence.h
> index c0c916c264b4..598336cb61af 100644
> --- a/include/libcamera/fence.h
> +++ b/include/libcamera/fence.h
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2021, Google Inc.
>    *
> - * internal/fence.h - Synchronization fence
> + * Synchronization fence
>    */
>   
>   #pragma once
> diff --git a/src/android/camera_ops.cpp b/src/android/camera_ops.cpp
> index 8a3cfa175ff5..ecaac5a31c64 100644
> --- a/src/android/camera_ops.cpp
> +++ b/src/android/camera_ops.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2019, Google Inc.
>    *
> - * camera_ops.h - Android Camera HAL Operations
> + * Android Camera HAL Operations
>    */
>   
>   #include "camera_ops.h"
> diff --git a/src/android/mm/cros_frame_buffer_allocator.cpp b/src/android/mm/cros_frame_buffer_allocator.cpp
> index 0a5c59f2a697..264c0d481272 100644
> --- a/src/android/mm/cros_frame_buffer_allocator.cpp
> +++ b/src/android/mm/cros_frame_buffer_allocator.cpp
> @@ -2,8 +2,7 @@
>   /*
>    * Copyright (C) 2021, Google Inc.
>    *
> - * cros_frame_buffer.cpp - Allocate FrameBuffer for Chromium OS using
> - * CameraBufferManager
> + * Allocate FrameBuffer for Chromium OS using CameraBufferManager
>    */
>   
>   #include <memory>
> diff --git a/src/android/mm/generic_frame_buffer_allocator.cpp b/src/android/mm/generic_frame_buffer_allocator.cpp
> index 7ecef2c669df..79625a9a3c75 100644
> --- a/src/android/mm/generic_frame_buffer_allocator.cpp
> +++ b/src/android/mm/generic_frame_buffer_allocator.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2021, Google Inc.
>    *
> - * generic_camera_buffer.cpp - Allocate FrameBuffer using gralloc API
> + * Allocate FrameBuffer using gralloc API
>    */
>   
>   #include <dlfcn.h>
> diff --git a/src/apps/cam/sdl_sink.cpp b/src/apps/cam/sdl_sink.cpp
> index a2f4abc1ec8c..8355dd5ed56f 100644
> --- a/src/apps/cam/sdl_sink.cpp
> +++ b/src/apps/cam/sdl_sink.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2022, Ideas on Board Oy
>    *
> - * sdl_sink.h - SDL Sink
> + * SDL Sink
>    */
>   
>   #include "sdl_sink.h"
> diff --git a/src/apps/ipa-verify/main.cpp b/src/apps/ipa-verify/main.cpp
> index 76ba5073d25a..0903cd8512d3 100644
> --- a/src/apps/ipa-verify/main.cpp
> +++ b/src/apps/ipa-verify/main.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2023, Ideas on Board Oy
>    *
> - * ipa_verify.cpp - Verify signature on an IPA module
> + * Verify signature on an IPA module
>    */
>   
>   #include <iostream>
> diff --git a/src/apps/lc-compliance/helpers/capture.cpp b/src/apps/lc-compliance/helpers/capture.cpp
> index 5aab973f0392..90c1530baba8 100644
> --- a/src/apps/lc-compliance/helpers/capture.cpp
> +++ b/src/apps/lc-compliance/helpers/capture.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2020-2021, Google Inc.
>    *
> - * simple_capture.cpp - Simple capture helper
> + * Simple capture helper
>    */
>   
>   #include "capture.h"
> diff --git a/src/apps/lc-compliance/helpers/capture.h b/src/apps/lc-compliance/helpers/capture.h
> index 0574ab1c7ac7..19b6927c62b4 100644
> --- a/src/apps/lc-compliance/helpers/capture.h
> +++ b/src/apps/lc-compliance/helpers/capture.h
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2020-2021, Google Inc.
>    *
> - * simple_capture.h - Simple capture helper
> + * Simple capture helper
>    */
>   
>   #pragma once
> diff --git a/src/apps/qcam/format_converter.cpp b/src/apps/qcam/format_converter.cpp
> index de76b32c7ffd..32123493f905 100644
> --- a/src/apps/qcam/format_converter.cpp
> +++ b/src/apps/qcam/format_converter.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2019, Google Inc.
>    *
> - * format_convert.cpp - qcam - Convert buffer to RGB
> + * Convert buffer to RGB
>    */


This drops the "qcam -" as well as the "format_convert.cpp" - I think that's fine to do but I 
thought I'd mention it incase it was accidental

>   
>   #include "format_converter.h"
> diff --git a/src/apps/qcam/format_converter.h b/src/apps/qcam/format_converter.h
> index 37dbfae2d344..819a87a5b3f4 100644
> --- a/src/apps/qcam/format_converter.h
> +++ b/src/apps/qcam/format_converter.h
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2019, Google Inc.
>    *
> - * format_convert.h - qcam - Convert buffer to RGB
> + * Convert buffer to RGB
>    */
>   
>   #pragma once
> diff --git a/src/apps/qcam/message_handler.h b/src/apps/qcam/message_handler.h
> index 56294d37ce2f..92ef74d1e810 100644
> --- a/src/apps/qcam/message_handler.h
> +++ b/src/apps/qcam/message_handler.h
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2020, Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>    *
> - * message_handler.cpp - qcam - Log message handling
> + * Log message handling
>    */
>   
>   #pragma once
> diff --git a/src/apps/qcam/viewfinder_gl.cpp b/src/apps/qcam/viewfinder_gl.cpp
> index f83b99ad6272..9d2a69600db1 100644
> --- a/src/apps/qcam/viewfinder_gl.cpp
> +++ b/src/apps/qcam/viewfinder_gl.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2020, Linaro
>    *
> - * viewfinderGL.cpp - OpenGL Viewfinder for rendering by OpenGL shader
> + * OpenGL Viewfinder for rendering by OpenGL shader
>    */
>   
>   #include "viewfinder_gl.h"
> diff --git a/src/apps/qcam/viewfinder_gl.h b/src/apps/qcam/viewfinder_gl.h
> index 68c2912df12f..23744b411c86 100644
> --- a/src/apps/qcam/viewfinder_gl.h
> +++ b/src/apps/qcam/viewfinder_gl.h
> @@ -2,8 +2,7 @@
>   /*
>    * Copyright (C) 2020, Linaro
>    *
> - * viewfinder_GL.h - OpenGL Viewfinder for rendering by OpenGL shader
> - *
> + * OpenGL Viewfinder for rendering by OpenGL shader
>    */
>   
>   #pragma once
> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp
> index 469ac8104739..e163ce4141b0 100644
> --- a/src/gstreamer/gstlibcamera-utils.cpp
> +++ b/src/gstreamer/gstlibcamera-utils.cpp
> @@ -3,7 +3,7 @@
>    * Copyright (C) 2020, Collabora Ltd.
>    *     Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
>    *
> - * gstlibcamera-utils.c - GStreamer libcamera Utility Function
> + * GStreamer libcamera Utility Function
>    */
>   
>   #include "gstlibcamera-utils.h"
> diff --git a/src/gstreamer/gstlibcamera.cpp b/src/gstreamer/gstlibcamera.cpp
> index 52388b5eaac0..bff989794836 100644
> --- a/src/gstreamer/gstlibcamera.cpp
> +++ b/src/gstreamer/gstlibcamera.cpp
> @@ -3,7 +3,7 @@
>    * Copyright (C) 2019, Collabora Ltd.
>    *     Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
>    *
> - * gstlibcamera.c - GStreamer plugin
> + * GStreamer plugin
>    */
>   
>   #include "gstlibcameraprovider.h"
> diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp
> index ce3e0a08e904..4fb1b00771f0 100644
> --- a/src/gstreamer/gstlibcameraprovider.cpp
> +++ b/src/gstreamer/gstlibcameraprovider.cpp
> @@ -3,7 +3,7 @@
>    * Copyright (C) 2020, Collabora Ltd.
>    *     Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
>    *
> - * gstlibcameraprovider.c - GStreamer Device Provider
> + * GStreamer Device Provider
>    */
>   
>   #include <array>
> diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp
> index c9b5548c4548..0e0114f6da44 100644
> --- a/src/ipa/ipu3/algorithms/agc.cpp
> +++ b/src/ipa/ipu3/algorithms/agc.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2021, Ideas On Board
>    *
> - * ipu3_agc.cpp - AGC/AEC mean-based control algorithm
> + * AGC/AEC mean-based control algorithm
>    */
>   
>   #include "agc.h"
> diff --git a/src/ipa/ipu3/algorithms/blc.h b/src/ipa/ipu3/algorithms/blc.h
> index 292bf67b02ff..6274804548bb 100644
> --- a/src/ipa/ipu3/algorithms/blc.h
> +++ b/src/ipa/ipu3/algorithms/blc.h
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2021, Google inc.
>    *
> - * black_correction.h - IPU3 Black Level Correction control
> + * IPU3 Black Level Correction control
>    */
>   
>   #pragma once
> diff --git a/src/ipa/rpi/controller/denoise_algorithm.h b/src/ipa/rpi/controller/denoise_algorithm.h
> index 444cbc259889..b9a2a33cd741 100644
> --- a/src/ipa/rpi/controller/denoise_algorithm.h
> +++ b/src/ipa/rpi/controller/denoise_algorithm.h
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2021, Raspberry Pi Ltd
>    *
> - * denoise.h - Denoise control algorithm interface
> + * Denoise control algorithm interface
>    */
>   #pragma once
>   
> diff --git a/src/ipa/rpi/controller/rpi/denoise.cpp b/src/ipa/rpi/controller/rpi/denoise.cpp
> index 154ee604ddd0..ba851658d085 100644
> --- a/src/ipa/rpi/controller/rpi/denoise.cpp
> +++ b/src/ipa/rpi/controller/rpi/denoise.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2022 Raspberry Pi Ltd
>    *
> - * Denoise.cpp - Denoise (spatial, colour, temporal) control algorithm
> + * Denoise (spatial, colour, temporal) control algorithm
>    */
>   #include "denoise.h"
>   
> diff --git a/src/ipa/rpi/controller/tonemap_status.h b/src/ipa/rpi/controller/tonemap_status.h
> index 0e6399467869..41a7bf2ffa7c 100644
> --- a/src/ipa/rpi/controller/tonemap_status.h
> +++ b/src/ipa/rpi/controller/tonemap_status.h
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2022 Raspberry Pi Ltd
>    *
> - * hdr.h - Tonemap control algorithm status
> + * Tonemap control algorithm status
>    */
>   #pragma once
>   
> diff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp
> index d2159a512433..4fa4fbcf5fbd 100644
> --- a/src/ipa/rpi/vc4/vc4.cpp
> +++ b/src/ipa/rpi/vc4/vc4.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2019-2021, Raspberry Pi Ltd
>    *
> - * rpi.cpp - Raspberry Pi VC4/BCM2835 ISP IPA.
> + * Raspberry Pi VC4/BCM2835 ISP IPA.
>    */
>   
>   #include <string.h>
> diff --git a/src/libcamera/base/backtrace.cpp b/src/libcamera/base/backtrace.cpp
> index be30589d255e..0b04629c9322 100644
> --- a/src/libcamera/base/backtrace.cpp
> +++ b/src/libcamera/base/backtrace.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2021, Ideas on Board Oy
>    *
> - * backtrace.h - Call stack backtraces
> + * Call stack backtraces
>    */
>   
>   #include <libcamera/base/backtrace.h>
> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp
> index 355f3adad68f..8837e6f8b6d0 100644
> --- a/src/libcamera/camera_manager.cpp
> +++ b/src/libcamera/camera_manager.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2018, Google Inc.
>    *
> - * camera_manager.h - Camera management
> + * Camera management
>    */
>   
>   #include "libcamera/internal/camera_manager.h"
> diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp
> index 777441e8222a..94d0a575b01b 100644
> --- a/src/libcamera/delayed_controls.cpp
> +++ b/src/libcamera/delayed_controls.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2020, Raspberry Pi Ltd
>    *
> - * delayed_controls.h - Helper to deal with controls that take effect with a delay
> + * Helper to deal with controls that take effect with a delay
>    */
>   
>   #include "libcamera/internal/delayed_controls.h"
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
> index 9195aad2cff2..c49017d1fb29 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2020, Google Inc.
>    *
> - * rkisp1path.cpp - Rockchip ISP1 path helper
> + * Rockchip ISP1 path helper
>    */
>   
>   #include "rkisp1_path.h"
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.h b/src/libcamera/pipeline/rkisp1/rkisp1_path.h
> index cd77957ee4a6..08edefecaa00 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.h
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.h
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2020, Google Inc.
>    *
> - * rkisp1path.h - Rockchip ISP1 path helper
> + * Rockchip ISP1 path helper
>    */
>   
>   #pragma once
> diff --git a/src/v4l2/v4l2_camera_file.cpp b/src/v4l2/v4l2_camera_file.cpp
> index 0a41587ca90b..d8fe854b6d06 100644
> --- a/src/v4l2/v4l2_camera_file.cpp
> +++ b/src/v4l2/v4l2_camera_file.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2020, Google Inc.
>    *
> - * v4l2_camera_file.h - V4L2 compatibility camera file information
> + * V4L2 compatibility camera file information
>    */
>   
>   #include "v4l2_camera_file.h"
> diff --git a/test/bayer-format.cpp b/test/bayer-format.cpp
> index 54f03487fa0e..f8d1980498c1 100644
> --- a/test/bayer-format.cpp
> +++ b/test/bayer-format.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2020, Sebastian Fricke
>    *
> - * bayer_format.cpp - BayerFormat class tests
> + * BayerFormat class tests
>    */
>   
>   #include <iostream>
> diff --git a/test/byte-stream-buffer.cpp b/test/byte-stream-buffer.cpp
> index 04ff0571b6db..04aab3d28599 100644
> --- a/test/byte-stream-buffer.cpp
> +++ b/test/byte-stream-buffer.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2018, Google Inc.
>    *
> - * byte_stream_buffer.cpp - ByteStreamBuffer tests
> + * ByteStreamBuffer tests
>    */
>   
>   #include <array>
> diff --git a/test/controls/control_info_map.cpp b/test/controls/control_info_map.cpp
> index 29b33515e48c..b0be14b583d0 100644
> --- a/test/controls/control_info_map.cpp
> +++ b/test/controls/control_info_map.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2019, Google Inc.
>    *
> - * control_info.cpp - ControlInfoMap tests
> + * ControlInfoMap tests
>    */
>   
>   #include <iostream>
> diff --git a/test/gstreamer/gstreamer_device_provider_test.cpp b/test/gstreamer/gstreamer_device_provider_test.cpp
> index 237af8cd934e..8b8e7cba21e4 100644
> --- a/test/gstreamer/gstreamer_device_provider_test.cpp
> +++ b/test/gstreamer/gstreamer_device_provider_test.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2023, Umang Jain <umang.jain at ideasonboard.com>
>    *
> - * gstreamer_single_stream_test.cpp - GStreamer single stream capture test
> + * GStreamer single stream capture test
>    */
>   
>   #include <vector>
> diff --git a/test/gstreamer/gstreamer_test.h b/test/gstreamer/gstreamer_test.h
> index aa2261e2dd5c..abb37c1b2f2d 100644
> --- a/test/gstreamer/gstreamer_test.h
> +++ b/test/gstreamer/gstreamer_test.h
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2021, Vedant Paranjape
>    *
> - * gstreamer_test.cpp - GStreamer test base class
> + * GStreamer test base class
>    */
>   
>   #pragma once
> diff --git a/test/log/log_api.cpp b/test/log/log_api.cpp
> index 5311896095a9..0b999738d891 100644
> --- a/test/log/log_api.cpp
> +++ b/test/log/log_api.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2019, Google Inc.
>    *
> - * log.cpp - log API test
> + * log API test
>    */
>   
>   #include <algorithm>
> diff --git a/test/object-delete.cpp b/test/object-delete.cpp
> index 80b7dc41cd37..676c3970328a 100644
> --- a/test/object-delete.cpp
> +++ b/test/object-delete.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2020, Google Inc.
>    *
> - * object.cpp - Object deletion tests
> + * Object deletion tests
>    */
>   
>   #include <iostream>
> diff --git a/test/shared-fd.cpp b/test/shared-fd.cpp
> index 997d7be18c47..57199dfe7725 100644
> --- a/test/shared-fd.cpp
> +++ b/test/shared-fd.cpp
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2019, Google Inc.
>    *
> - * shared_fd.cpp - SharedFD test
> + * SharedFD test
>    */
>   
>   #include <fcntl.h>
> diff --git a/test/v4l2_videodevice/v4l2_videodevice_test.h b/test/v4l2_videodevice/v4l2_videodevice_test.h
> index d2de1a6de29f..b5871ce69e18 100644
> --- a/test/v4l2_videodevice/v4l2_videodevice_test.h
> +++ b/test/v4l2_videodevice/v4l2_videodevice_test.h
> @@ -2,7 +2,7 @@
>   /*
>    * Copyright (C) 2018, Google Inc.
>    *
> - * vl42device_test.h - libcamera v4l2device test base class
> + * libcamera v4l2device test base class
>    */
>   
>   #pragma once
> diff --git a/utils/gen-ipa-pub-key.py b/utils/gen-ipa-pub-key.py
> index a4a1f7b79337..dc3e7d5ff471 100755
> --- a/utils/gen-ipa-pub-key.py
> +++ b/utils/gen-ipa-pub-key.py
> @@ -4,7 +4,7 @@
>   #
>   # Author: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>   #
> -# ipa-gen-key.py - Generate the IPA module signing public key
> +# Generate the IPA module signing public key
>   
>   import string
>   import subprocess
> diff --git a/utils/rkisp1/rkisp1-capture.sh b/utils/rkisp1/rkisp1-capture.sh
> index c5f859f21001..d767e31daf78 100755
> --- a/utils/rkisp1/rkisp1-capture.sh
> +++ b/utils/rkisp1/rkisp1-capture.sh
> @@ -4,8 +4,7 @@
>   #
>   # Author: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>   #
> -# rkisp-capture.sh - Capture processed frames from cameras based on the
> -# Rockchip ISP1
> +# Capture processed frames from cameras based on the Rockchip ISP1
>   #
>   # The scripts makes use of the following tools, which are expected to be
>   # executable from the system-wide path or from the local directory:


More information about the libcamera-devel mailing list