[PATCH v1] gstreamer: Use copied camera name
Barnabás Pőcze
pobrn at protonmail.com
Tue May 14 20:02:07 CEST 2024
It seems the intent is to use the copied camera name to avoid
concurrency problems related to `gst_libcamera_src_set_property()`.
However, the current code makes the copy, but does not actually
use it. So fix that.
Fixes: 58feb69f852289 ("gst: libcamerasrc: Implement selection and acquisition")
Signed-off-by: Barnabás Pőcze <pobrn at protonmail.com>
---
src/gstreamer/gstlibcamerasrc.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp
index a284110b..9680d809 100644
--- a/src/gstreamer/gstlibcamerasrc.cpp
+++ b/src/gstreamer/gstlibcamerasrc.cpp
@@ -377,10 +377,10 @@ gst_libcamera_src_open(GstLibcameraSrc *self)
}
if (camera_name) {
- cam = cm->get(self->camera_name);
+ cam = cm->get(camera_name);
if (!cam) {
GST_ELEMENT_ERROR(self, RESOURCE, NOT_FOUND,
- ("Could not find a camera named '%s'.", self->camera_name),
+ ("Could not find a camera named '%s'.", camera_name),
("libcamera::CameraMananger::get() returned nullptr"));
return false;
}
--
2.45.0
More information about the libcamera-devel
mailing list