[PATCH v1] ipa: rpi: awb: Fix incorrect parameter retrieval

Kieran Bingham kieran.bingham at ideasonboard.com
Mon May 20 14:27:26 CEST 2024


Quoting Dan Scally (2024-05-20 11:57:51)
> 
> On 20/05/2024 10:58, Kieran Bingham wrote:
> > Quoting Barnabás Pőcze (2024-05-20 04:50:22)
> >> During the refactoring in the mentioned commit the quotation
> >> marks around the word *fast* were missed. Unfortunately there
> >> was a variable named *fast* and an suitable overload for `operator[]`
> >> for things to compile fine.
> > Ouch!
> >
> >> Fixes: c1597f98965461 ("ipa: raspberrypi: Use YamlParser to replace dependency on boost")
> > And this has been in for quite some time, Great find!
> >
> >
> > Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> 
> Great spot indeed.
> 
> 
> Reviewed-by: Daniel Scally <dan.scally at ideasonboard.com>

https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1181634 : success : patchwork/4317

CI passes here, but I'll hold off to give RPi time to check here before
merging, but I believe this is good to go already.

--
Kieran




> 
> >
> >
> >> Signed-off-by: Barnabás Pőcze <pobrn at protonmail.com>
> >> ---
> >>   src/ipa/rpi/controller/rpi/awb.cpp | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp
> >> index abe5906e..94ecbfc2 100644
> >> --- a/src/ipa/rpi/controller/rpi/awb.cpp
> >> +++ b/src/ipa/rpi/controller/rpi/awb.cpp
> >> @@ -161,7 +161,7 @@ int AwbConfig::read(const libcamera::YamlObject &params)
> >>                          bayes = false;
> >>                  }
> >>          }
> >> -       fast = params[fast].get<int>(bayes); /* default to fast for Bayesian, otherwise slow */
> >> +       fast = params["fast"].get<int>(bayes); /* default to fast for Bayesian, otherwise slow */
> >>          whitepointR = params["whitepoint_r"].get<double>(0.0);
> >>          whitepointB = params["whitepoint_b"].get<double>(0.0);
> >>          if (bayes == false)
> >> -- 
> >> 2.45.1
> >>
> >>


More information about the libcamera-devel mailing list