[PATCH] ipa: rpi: Make monoSensor() accessor const

Jacopo Mondi jacopo.mondi at ideasonboard.com
Thu May 23 10:36:28 CEST 2024


Hi think this got from review when applying patches ?

On Sun, May 19, 2024 at 08:56:50PM GMT, Laurent Pinchart wrote:
> The ipa::RPi::IpaBase::monoSensor() function doesn't modify the class.
> Make it const.
>
> Fixes: 2031e2f29014 ("ipa: rpi: Add accessor function for monoSensor_")
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>

> ---
>  src/ipa/rpi/common/ipa_base.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h
> index a95cda1ffe51..1a811beb31f2 100644
> --- a/src/ipa/rpi/common/ipa_base.h
> +++ b/src/ipa/rpi/common/ipa_base.h
> @@ -49,7 +49,7 @@ public:
>  	void processStats(const ProcessParams &params) override;
>
>  protected:
> -	bool monoSensor()
> +	bool monoSensor() const
>  	{
>  		return monoSensor_;
>  	}
>
> base-commit: aee16c06913422a0ac84ee3217f87a9795e3c2d9
> --
> Regards,
>
> Laurent Pinchart
>


More information about the libcamera-devel mailing list