[PATCH v3 1/5] libcamera: software_isp: Use a specific integer type for black level
Milan Zamazal
mzamazal at redhat.com
Thu May 23 13:26:52 CEST 2024
The documented range of values corresponds to uint8_t, so let's use that
type.
Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Andrei Konovalov <andrey.konovalov.ynk at gmail.com>
---
src/ipa/simple/black_level.cpp | 2 +-
src/ipa/simple/black_level.h | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/ipa/simple/black_level.cpp b/src/ipa/simple/black_level.cpp
index 53b4c040..cc490eb5 100644
--- a/src/ipa/simple/black_level.cpp
+++ b/src/ipa/simple/black_level.cpp
@@ -43,7 +43,7 @@ BlackLevel::BlackLevel()
* \return The black level, in the range from 0 (minimum) to 255 (maximum).
* If the black level couldn't be determined yet, return 0.
*/
-unsigned int BlackLevel::get() const
+uint8_t BlackLevel::get() const
{
return blackLevelSet_ ? blackLevel_ : 0;
}
diff --git a/src/ipa/simple/black_level.h b/src/ipa/simple/black_level.h
index 25094217..5e032f9f 100644
--- a/src/ipa/simple/black_level.h
+++ b/src/ipa/simple/black_level.h
@@ -8,6 +8,7 @@
#pragma once
#include <array>
+#include <stdint.h>
#include "libcamera/internal/software_isp/swisp_stats.h"
@@ -17,11 +18,11 @@ class BlackLevel
{
public:
BlackLevel();
- unsigned int get() const;
+ uint8_t get() const;
void update(SwIspStats::Histogram &yHistogram);
private:
- unsigned int blackLevel_;
+ uint8_t blackLevel_;
bool blackLevelSet_;
};
--
2.42.0
More information about the libcamera-devel
mailing list