[PATCH v4 4/5] libcamera: software_isp: Remove DebayerParams::kGain10

[Laurent Pinchart]

Hi Milan,

Thank you for the patch.

On Tue, May 28, 2024 at 06:11:25PM +0200, Milan Zamazal wrote:
> The constant is used in a single place internally and doesn't belong to
> DebayerParams anymore.  Let's use 256 directly.
> 
> Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
> Reviewed-by: Andrei Konovalov <andrey.konovalov.ynk at gmail.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  include/libcamera/internal/software_isp/debayer_params.h | 1 -
>  src/ipa/simple/soft_simple.cpp                           | 3 +--
>  src/libcamera/software_isp/debayer.cpp                   | 5 -----
>  3 files changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h
> index 69fed1e7..2f75b4b5 100644
> --- a/include/libcamera/internal/software_isp/debayer_params.h
> +++ b/include/libcamera/internal/software_isp/debayer_params.h
> @@ -16,7 +16,6 @@
>  namespace libcamera {
>  
>  struct DebayerParams {
> -	static constexpr unsigned int kGain10 = 256;
>  	static constexpr unsigned int kRGBLookupSize = 256;
>  	static constexpr float kGamma = 0.5;
>  
> diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp
> index 2c9fe98e..26597c99 100644
> --- a/src/ipa/simple/soft_simple.cpp
> +++ b/src/ipa/simple/soft_simple.cpp
> @@ -289,8 +289,7 @@ void IPASoftSimple::processStats(const ControlList &sensorControls)
>  
>  	for (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {
>  		constexpr unsigned int div =
> -			DebayerParams::kRGBLookupSize * DebayerParams::kGain10 /
> -			kGammaLookupSize;
> +			DebayerParams::kRGBLookupSize * 256 / kGammaLookupSize;
>  		unsigned int idx;
>  
>  		/* Apply gamma after gain! */
> diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp
> index 028bf27e..80bf5dbe 100644
> --- a/src/libcamera/software_isp/debayer.cpp
> +++ b/src/libcamera/software_isp/debayer.cpp
> @@ -18,11 +18,6 @@ namespace libcamera {
>   * \brief Struct to hold the debayer parameters.
>   */
>  
> -/**
> - * \var DebayerParams::kGain10
> - * \brief const value for 1.0 gain
> - */
> -
>  /**
>   * \var DebayerParams::kRGBLookupSize
>   * \brief Size of a color lookup table

-- 
Regards,

Laurent Pinchart