[PATCH v3 0/4] ipa: Move Pwl from Raspberry Pi to libipa

[Kieran Bingham]

Hi Naush, David,

Do you have any objections or concerns here? If not could you provide an
Acked-by: tag please?

--
Kieran


Quoting Paul Elder (2024-05-29 20:26:07)
> This patch series moves the piecewise linear function class from
> the Rasberry Pi IPA to libipa so that all IPAs can use it.
> 
> First an addition to the geometry header is needed, to add a
> floating-point version of the Point class, then the pwl is copied over,
> and the Raspberry Pi IPA is converted to use the libipa Pwl class.
> 
> The main changes in v2 are s/FPoint/PointF/g and improving the
> documentation.
> 
> v3 has almost no change...
> 
> Paul Elder (4):
>   libcamera: geometry: Add floating-point version of Point class
>   ipa: libipa: Copy pwl from rpi
>   ipa: libipa: pwl: Clean up Pwl class to match libcamera
>   ipa: rpi: controller: Use libipa's Pwl class
> 
>  include/libcamera/geometry.h               |  65 ++++
>  src/ipa/libipa/meson.build                 |   2 +
>  src/ipa/libipa/pwl.cpp                     | 371 +++++++++++++++++++++
>  src/ipa/libipa/pwl.h                       |  98 ++++++
>  src/ipa/rpi/controller/cac_status.h        |   2 -
>  src/ipa/rpi/controller/contrast_status.h   |   4 +-
>  src/ipa/rpi/controller/meson.build         |   2 +-
>  src/ipa/rpi/controller/rpi/af.cpp          |   4 +-
>  src/ipa/rpi/controller/rpi/af.h            |   5 +-
>  src/ipa/rpi/controller/rpi/agc_channel.cpp |   8 +-
>  src/ipa/rpi/controller/rpi/agc_channel.h   |   7 +-
>  src/ipa/rpi/controller/rpi/awb.cpp         |  40 +--
>  src/ipa/rpi/controller/rpi/awb.h           |  23 +-
>  src/ipa/rpi/controller/rpi/ccm.cpp         |   4 +-
>  src/ipa/rpi/controller/rpi/ccm.h           |   5 +-
>  src/ipa/rpi/controller/rpi/contrast.cpp    |  14 +-
>  src/ipa/rpi/controller/rpi/contrast.h      |   5 +-
>  src/ipa/rpi/controller/rpi/geq.cpp         |   5 +-
>  src/ipa/rpi/controller/rpi/geq.h           |   4 +-
>  src/ipa/rpi/controller/rpi/hdr.cpp         |   8 +-
>  src/ipa/rpi/controller/rpi/hdr.h           |   9 +-
>  src/ipa/rpi/controller/rpi/tonemap.cpp     |   2 +-
>  src/ipa/rpi/controller/rpi/tonemap.h       |   5 +-
>  src/ipa/rpi/controller/tonemap_status.h    |   4 +-
>  src/libcamera/geometry.cpp                 | 123 ++++++-
>  test/geometry.cpp                          | 355 ++++++++++++++++++++
>  26 files changed, 1097 insertions(+), 77 deletions(-)
>  create mode 100644 src/ipa/libipa/pwl.cpp
>  create mode 100644 src/ipa/libipa/pwl.h
> 
> -- 
> 2.39.2
>