[PATCH] test: ipa: rkisp1-utils: Fix capitalization of hex numbers

Laurent Pinchart laurent.pinchart at ideasonboard.com
Fri May 31 14:19:27 CEST 2024


On Fri, May 31, 2024 at 12:52:21PM +0100, Kieran Bingham wrote:
> Quoting Paul Elder (2024-05-31 12:42:16)
> > Fix capitalization of the hexdecimal numbers in the test for conversion
> > between floating point and fixed point numbers.
> 
> I wonder when we'll get this in a checkstyle rule :-)

Patches are on the list :-)

> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> > Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> > ---
> >  test/ipa/rkisp1/rkisp1-utils.cpp | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> > 
> > diff --git a/test/ipa/rkisp1/rkisp1-utils.cpp b/test/ipa/rkisp1/rkisp1-utils.cpp
> > index e9244ec44..9fff0cdce 100644
> > --- a/test/ipa/rkisp1/rkisp1-utils.cpp
> > +++ b/test/ipa/rkisp1/rkisp1-utils.cpp
> > @@ -53,13 +53,13 @@ protected:
> >                  * affect the result.
> >                  */
> >                 std::map<double, uint16_t> testCases = {
> > -                       { 7.992, 0x3FF },
> > -                       { 7.992, 0xBFF },
> > -                       {   0.2, 0x01A },
> > -                       {  -0.2, 0x7E6 },
> > -                       {  -0.8, 0x79A },
> > -                       {  -0.4, 0x7CD },
> > -                       {  -1.4, 0x74D },
> > +                       { 7.992, 0x3ff },
> > +                       { 7.992, 0xbff },
> > +                       {   0.2, 0x01a },
> > +                       {  -0.2, 0x7e6 },
> > +                       {  -0.8, 0x79a },
> > +                       {  -0.4, 0x7cd },
> > +                       {  -1.4, 0x74d },
> >                         {    -8, 0x400 },
> >                         {     0, 0 },
> >                 };

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list