[PATCH v2 2/6] test: fence: Turn class member variable into local variable

[Dan Scally]

Hi Laurent

On 29/05/2024 16:43, Laurent Pinchart wrote:
> The fence_ class member variable is only used locally in the
> FenceTest::run() function. Make it a local variable.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
Reviewed-by: Daniel Scally <dan.scally at ideasonboard.com>
>   test/fence.cpp | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/test/fence.cpp b/test/fence.cpp
> index ada650ff2417..c282886287aa 100644
> --- a/test/fence.cpp
> +++ b/test/fence.cpp
> @@ -43,7 +43,6 @@ private:
>   
>   	void signalFence();
>   
> -	std::unique_ptr<Fence> fence_;
>   	EventDispatcher *dispatcher_;
>   	UniqueFD eventFd_;
>   	UniqueFD eventFd2_;
> @@ -274,13 +273,14 @@ int FenceTest::run()
>   		int ret;
>   		if (i == expiredRequestId_) {
>   			/* This request will have a fence, and it will expire. */
> -			fence_ = std::make_unique<Fence>(std::move(eventFd_));
> -			if (!fence_->isValid()) {
> +			std::unique_ptr<Fence> fence =
> +				std::make_unique<Fence>(std::move(eventFd_));
> +			if (!fence->isValid()) {
>   				cerr << "Fence should be valid" << endl;
>   				return TestFail;
>   			}
>   
> -			ret = request->addBuffer(stream_, buffer.get(), std::move(fence_));
> +			ret = request->addBuffer(stream_, buffer.get(), std::move(fence));
>   		} else {
>   			/* All other requests will have no Fence. */
>   			ret = request->addBuffer(stream_, buffer.get());