[PATCH v3] gstreamer: Implement caps negotiation for video/x-bayer

[Kieran Bingham]

Quoting Kieran Bingham (2024-11-04 15:12:51)
> Quoting Kieran Bingham (2024-11-04 15:02:28)
> > Quoting Nicolas Dufresne (2024-11-04 14:58:01)
> > > Thanks.
> > > 
> > > Le lundi 04 novembre 2024 à 12:36 +0100, mailinglist1 at johanneskirchmair.de a
> > > écrit :
> > > > From: Johannes Kirchmair <johannes.kirchmair at skidata.com>
> > > > 
> > > > The parsing of video/x-bayer sources from string makes it possible to
> > > > use cameras providing e.g SGRBG8 streams via gst-launch.
> > > > 
> > > > Like:
> > > > gst-launch-1.0 libcamerasrc camera-name=<cam> ! video/x-bayer,format=grbg
> > > > 
> > > > Without this change the gstreamer plugin complains about "Unsupported
> > > > media type: video/x-bayer".
> > > > 
> > > > Signed-off-by: Johannes Kirchmair <johannes.kirchmair at skidata.com>
> > > 
> > > Reviewed-by: Nicolas Dufresne <nicolas.dufresne at collabora.com>
> > 
> > 
> > Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> > 
> > 
> > I'll merge this assuming the CI tests all pass cleanly.
> 
> https://gitlab.freedesktop.org/camera/libcamera/-/jobs/66072263 reports:
> 
> ```
> 5c8010e4f8dc2d4e41ce817c03289b1155ccd659 gstreamer: Implement caps negotiation for video/x-bayer
> ------------------------------------------------------------------------------------------------
> No 'Signed-off-by' trailer matching author 'Johannes Kirchmair <johannes.kirchmair at skidata.com>', see Documentation/contributing.rst
> --- src/gstreamer/gstlibcamera-utils.cpp
> +++ src/gstreamer/gstlibcamera-utils.cpp
> @@ -283,7 +283,7 @@
>  static const gchar *
>  bayer_format_to_string(PixelFormat format)
>  {
> -       for (auto &b: bayer_map) {
> +       for (auto &b : bayer_map) {
>                 if (b.format == format)
>                         return b.name;
>         }
> @@ -293,7 +293,7 @@
>  static PixelFormat
>  bayer_format_from_string(const gchar *name)
>  {
> -       for (auto &b: bayer_map) {
> +       for (auto &b : bayer_map) {
>                 if (strcmp(b.name, name) == 0)
>                         return b.format;
>         }
> ---
> 3 potential issues detected, please review
> Cleaning up project directory and file based variables 00:02
> ERROR: Job failed: exit code 1
> ```
> 
> The no Signed-off-by is odd - as I can see it there, so I'll check that.
> Ah - it looks like the patch was missing the '---' separator before the
> changelog. I'll fix that.
> 
> I'll also add the appropriate spaces when merging...
> 
> Johannes, for future patches, please add the post-commit hook to your
> libcamera repository to run the checkstyle locally:

Argh, I did it again. Someone pinged me halfway through sending a mail
and I didn't complete it!

 - To add checkstyle locally, please run:

 cp utils/hooks/post-commit .git/hooks/post-commit

from the top of your libcamera tree.


--
Kieran