[PATCH 8/8] libcamera: Add new atomisp pipeline handler

[Laurent Pinchart]

Hi Hans,

(CC'ing Sakari)

Thank you for the patch.

A few high-level questions first.

On Sun, Nov 03, 2024 at 04:22:05PM +0100, Hans de Goede wrote:
> Add a basic atomisp pipeline handler which supports configuring
> the pipeline, capturing frames and selecting front/back sensor.
> 
> The atomisp ISP needs some extra lines/columns when debayering and also
> has some max resolution limitations, this causes the available output
> resolutions to differ from the sensor resolutions.
> 
> The atomisp driver's Android heritage means that it mostly works as a non
> media-controller centric v4l2 device, primarily controlled through its
> /dev/video# node.

Could that be fixed on the kernel side (assuming someone would be able
to do the work of course) ?

> The driver takes care of setting up the pipeline itself
> propagating try / set fmt calls down from its single /dev/video# node to
> the selected sensor taking the necessary padding, etc. into account.
> 
> Therefor things like getting the list of support formats / sizes and
> setFmt() calls are all done on the /dev/video# node instead of on subdevs,
> this avoids having to duplicate the padding, etc. logic in the pipeline
> handler.
> 
> Since the statistics buffers which we get from the ISP2 are not documented

Could the stats format be reverse-engineered ? Or alternatively, could
Intel provide documentation (waving at Sakari) ?

> this uses the swstats_cpu and simple-IPA from the swisp. At the moment only
> aec/agc is supported.
> 
> awb support will be added in a follow-up patch.
> 
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>

[snip]

-- 
Regards,

Laurent Pinchart