[PATCH v3 03/11] include: linux: Add Mali-C55 Stats and Params V4L2 format
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Tue Nov 12 07:56:03 CET 2024
Hi Dan,
Thank you for the patch.
On Thu, Nov 07, 2024 at 11:48:11AM +0000, Daniel Scally wrote:
> Add the new format describing the Mali C55's Statistics and Parameters
> to videodev2.
Please indicate where this comes from (with a link to the corresponding
C55 driver patch series). Also, same comment as for '[PATCH v5 07/13]
include: media-bus-formats: Add Mali-C55 mbus codes', please explain in
the commit message that these manual changes are temporary, until the
C55 kernel driver gets merged, at which point the media bus codes will
be provided by upstream kernel headers.
With that,
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Acked-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> Acked-by: Nayden Kanchev <nayden.kanchev at arm.com>
> Co-developed-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
> Signed-off-by: Daniel Scally <dan.scally at ideasonboard.com>
> ---
> Changes in v2:
>
> - None
>
> Changes in v3:
>
> - None
>
> include/linux/videodev2.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
> index 3829c0b6..d2653b2e 100644
> --- a/include/linux/videodev2.h
> +++ b/include/linux/videodev2.h
> @@ -840,6 +840,9 @@ struct v4l2_pix_format {
> /* The metadata format identifier for FE stats buffers. */
> #define V4L2_META_FMT_RPI_FE_STATS v4l2_fourcc('R', 'P', 'F', 'S')
>
> +#define V4L2_META_FMT_MALI_C55_PARAMS v4l2_fourcc('C', '5', '5', 'P') /* ARM Mali-C55 Parameters */
> +#define V4L2_META_FMT_MALI_C55_3A_STATS v4l2_fourcc('C', '5', '5', 'S') /* ARM Mali-C55 3A Statistics */
> +
> /* priv field value to indicates that subsequent fields are valid. */
> #define V4L2_PIX_FMT_PRIV_MAGIC 0xfeedcafe
>
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list