[PATCH v3 7/8] gstreamer: Generate the new AEGC controls

[Laurent Pinchart]

Hi Nicolas,

On Wed, Nov 13, 2024 at 01:47:23PM -0500, Nicolas Dufresne wrote:
> Le mercredi 13 novembre 2024 à 22:12 +0900, Paul Elder a écrit :
> > Since AeEnable will be replaced with ExposureTimeMode and
> > AnalogueGainMode so that the two can be set between auto/manual
> > independently, update the gstreamer control ids generation to conform
> > with this.
> 
> Thanks for keeping GStreamer up-to-date!
> 
> Just an informative note, this is an API change, in this case we haven't
> released libcamera with ae-enable property yet, so no action needed. A similar
> change in the future would require emulating ae-enable on top of
> ExposureTimeMode, or some clear notice for the next release note.

We would opt for a clear notice, as we don't maintain backward
compatibility yet. Kieran already mentions ABI breakages in the release
notes, is there somewhere else the notice would need to be posted ?

> Reviewed-by: Nicolas Nicolas <nicolas.dufresne at collabora.com>
> 
> > Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> > 
> > ---
> > New in v3
> > ---
> >  utils/codegen/gen-gst-controls.py | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py
> > index 2601a67588a3..7dfd6b623b3d 100755
> > --- a/utils/codegen/gen-gst-controls.py
> > +++ b/utils/codegen/gen-gst-controls.py
> > @@ -19,8 +19,9 @@ from controls import Control
> >  
> >  
> >  exposed_controls = [
> > -    'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',
> > -    'ExposureValue', 'ExposureTime', 'AnalogueGain', 'AeFlickerPeriod',
> > +    'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',
> > +    'ExposureValue', 'ExposureTime', 'ExposureTimeMode',
> > +    'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',
> >      'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',
> >      'Saturation', 'Sharpness', 'ColourCorrectionMatrix', 'ScalerCrop',
> >      'DigitalGain', 'AfMode', 'AfRange', 'AfSpeed', 'AfMetering', 'AfWindows',

-- 
Regards,

Laurent Pinchart