[PATCH v6 10/14] libcamera: mali-c55: Propagate CSI-2 format to ISP
Daniel Scally
dan.scally at ideasonboard.com
Fri Nov 15 11:13:30 CET 2024
From: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
The latest version of the Mali C55 driver has changed the format
accepted by the ISP sink pad to be the 20-bit wide.
The CSI-2 receiver handles the format expansion internally by
propagating the sensor produced format from its sink to the 20-bit
expanded version on its source pad.
Instead of re-applying the sensor format to the CSI-2 receiver source
pad (which is now an invalid operation) read from there the format
propagated by the driver internally and further propagate it to the ISP
subdevice.
Reviewed-by: Daniel Scally <dan.scally at ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
Signed-off-by: Daniel Scally <dan.scally at ideasonboard.com>
---
Changes in v6:
- None
Changes in v5:
- None
src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
index a35aa92a..f5f98c59 100644
--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp
+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
@@ -767,7 +767,7 @@ int PipelineHandlerMaliC55::configure(Camera *camera,
if (ret)
return ret;
- ret = data->csi_->setFormat(1, &subdevFormat);
+ ret = data->csi_->getFormat(1, &subdevFormat);
if (ret)
return ret;
}
--
2.30.2
More information about the libcamera-devel
mailing list