[PATCH 2/4] libcamera: libipa: camera_sensor: Add Sony IMX327 cam helper

[Laurent Pinchart]

On Fri, Nov 15, 2024 at 08:51:15AM +0100, Geoffrey Van Landeghem wrote:
> Hi Laurent, not sure if I follow here but that's what I did in patch 1/4.
> See https://lists.libcamera.org/pipermail/libcamera-devel/2024-November/046559.html.

My bad, seems I should have started by waking up before replying.

> Or do you mean I should squash patch 2/4 into 1/4?

No, you've done it right.

By the way, the title of this patch should be "ipa: rpi: cam_helper: Add
Sony IMX327" as it doesn't touch libipa.

> Op vr 15 nov 2024 om 01:33 schreef Laurent Pinchart:
> > On Thu, Nov 14, 2024 at 11:37:35AM +0000, Dave Stevenson wrote:
> > > On Thu, 14 Nov 2024 at 09:00, Jacopo Mondi wrote:
> > > > On Wed, Nov 13, 2024 at 11:35:55PM +0100, Geoffrey Van Landeghem wrote:
> > > > > Signed-off-by: Geoffrey Van Landeghem <geoffrey.vl at gmail.com>
> > > > > ---
> > > > >  src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 1 +
> > > >
> > > > Why this has not been added to
> > > > src/ipa/libipa/camera_sensor_helpers.cpp and
> > > > src/libcamera/sensor/camera_sensor_properties.cpp ?
> > >
> > > Because it's already there
> > > https://git.linuxtv.org/libcamera.git/tree/src/ipa/libipa/camera_sensor_helper.cpp#n596
> > > https://git.linuxtv.org/libcamera.git/tree/src/libcamera/sensor/camera_sensor_properties.cpp#n133
> >
> > imx327 is, but imx462 is missing. Geoffrey, could you please add the
> > imx462 to the above files in the next version of this patch series ?
> >
> > > > >  1 file changed, 1 insertion(+)
> > > > >
> > > > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp
> > > > > index 0cc24a6d..3b87751e 100644
> > > > > --- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp
> > > > > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp
> > > > > @@ -73,4 +73,5 @@ static CamHelper *create()
> > > > >  }
> > > > >
> > > > >  static RegisterCamHelper reg("imx290", &create);
> > > > > +static RegisterCamHelper reg327("imx327", &create);
> > > > >  static RegisterCamHelper reg462("imx462", &create);

-- 
Regards,

Laurent Pinchart