[PATCH] ipa: rpi: awb: Disable CT search bias for Grey World AWB

Kieran Bingham kieran.bingham at ideasonboard.com
Tue Nov 19 10:24:49 CET 2024


Quoting Naushir Patuck (2024-11-19 08:45:25)
> If grey world AWB is setup in the tuning file, the CT curve will either
> be missing or invalid. Disable biasing the statistics for the search in
> such cases.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>

What's the fixes tag for this (mostly so I can report this as a fix in
the next release?)

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/ipa/rpi/controller/rpi/awb.cpp | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp
> index 9d8e170d1bfe..87b1b077ffb8 100644
> --- a/src/ipa/rpi/controller/rpi/awb.cpp
> +++ b/src/ipa/rpi/controller/rpi/awb.cpp
> @@ -459,10 +459,13 @@ void Awb::prepareStats()
>          * LSC has already been applied to the stats in this pipeline, so stop
>          * any LSC compensation.  We also ignore config_.fast in this version.
>          */
> +       const double biasCtR = config_.bayes && config_.ctR.size() ?
> +                              config_.ctR.eval(config_.biasCT) : 0;
> +       const double biasCtB = config_.bayes && config_.ctB.size() ?
> +                              config_.ctB.eval(config_.biasCT) : 0;
>         generateStats(zones_, statistics_, config_.minPixels,
>                       config_.minG, getGlobalMetadata(),
> -                     config_.biasProportion, config_.ctR.eval(config_.biasCT),
> -                     config_.ctB.eval(config_.biasCT));
> +                     config_.biasProportion, biasCtR, biasCtB);
>         /*
>          * apply sensitivities, so values appear to come from our "canonical"
>          * sensor.
> -- 
> 2.34.1
>


More information about the libcamera-devel mailing list