[PATCH v2 7/9] libipa: Use Matrix class from libcamera

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Nov 19 12:42:49 CET 2024


Hi Stefan,

Thank you for the patch.

On Tue, Nov 19, 2024 at 11:37:34AM +0100, Stefan Klug wrote:
> Use the Matrix class from libcamera/internal in libipa so that the one
> from libipa can be dropped later.
> 
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
> ---
>  src/ipa/libipa/vector.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h
> index 8612a06a2ab2..dcafcb1c0e96 100644
> --- a/src/ipa/libipa/vector.h
> +++ b/src/ipa/libipa/vector.h
> @@ -14,9 +14,9 @@
>  #include <libcamera/base/log.h>
>  #include <libcamera/base/span.h>
>  
> -#include "libcamera/internal/yaml_parser.h"
> +#include "libcamera/internal/matrix.h"
>  

You can drop this blank line.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> -#include "matrix.h"
> +#include "libcamera/internal/yaml_parser.h"
>  
>  namespace libcamera {
>  

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list