[PATCH v3 7/8] gstreamer: Generate the new AEGC controls

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Nov 20 14:44:29 CET 2024


Hi Paul,

Thank you for the patch.

On Wed, Nov 13, 2024 at 10:12:55PM +0900, Paul Elder wrote:
> Since AeEnable will be replaced with ExposureTimeMode and
> AnalogueGainMode so that the two can be set between auto/manual
> independently, update the gstreamer control ids generation to conform
> with this.
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> 
> ---
> New in v3
> ---
>  utils/codegen/gen-gst-controls.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py
> index 2601a67588a3..7dfd6b623b3d 100755
> --- a/utils/codegen/gen-gst-controls.py
> +++ b/utils/codegen/gen-gst-controls.py
> @@ -19,8 +19,9 @@ from controls import Control
>  
>  
>  exposed_controls = [
> -    'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',
> -    'ExposureValue', 'ExposureTime', 'AnalogueGain', 'AeFlickerPeriod',
> +    'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',
> +    'ExposureValue', 'ExposureTime', 'ExposureTimeMode',
> +    'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',
>      'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',
>      'Saturation', 'Sharpness', 'ColourCorrectionMatrix', 'ScalerCrop',
>      'DigitalGain', 'AfMode', 'AfRange', 'AfSpeed', 'AfMetering', 'AfWindows',

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list