[PATCH v3 8/8] controls: Remove AeEnable and AeLocked

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Nov 20 14:44:58 CET 2024


Hi Paul,

Thank you for the patch.

On Wed, Nov 13, 2024 at 10:12:56PM +0900, Paul Elder wrote:
> From: Jacopo Mondi <jacopo at jmondi.org>
> 
> Now that the codebase has been ported to use the new AEGC controls
> remove the definition of AeEnable and AeLocked.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> 
> ---
> No change in v3
> ---
>  src/libcamera/control_ids_core.yaml | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml
> index 98ef0736aa1b..fc519dea590a 100644
> --- a/src/libcamera/control_ids_core.yaml
> +++ b/src/libcamera/control_ids_core.yaml
> @@ -8,24 +8,6 @@
>  # set through Request::controls() and returned out through Request::metadata().
>  vendor: libcamera
>  controls:
> -  - AeEnable:
> -      type: bool
> -      description: |
> -        Enable or disable the AE.
> -
> -        \sa ExposureTime AnalogueGain
> -
> -  - AeLocked:
> -      type: bool
> -      description: |
> -        Report the lock status of a running AE algorithm.
> -
> -        If the AE algorithm is locked the value shall be set to true, if it's
> -        converging it shall be set to false. If the AE algorithm is not
> -        running the control shall not be present in the metadata control list.
> -
> -        \sa AeEnable
> -
>    - AeState:
>        type: int32_t
>        description: |

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list