[PATCH v3 4/8] test: ipa_data_serialization: Use ExposureTimeMode
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Wed Nov 20 14:48:11 CET 2024
Hi Paul,
Thank you for the patch.
On Wed, Nov 13, 2024 at 10:12:52PM +0900, Paul Elder wrote:
> From: Jacopo Mondi <jacopo at jmondi.org>
>
> Replace the deprecated AeEnable control with ExposureTimeMode
> in ipa_data_serialization test.
>
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>
>
> ---
> No change in v3
> ---
> test/serialization/ipa_data_serializer_test.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp
> index aea63c73187e..1ec8b2b469b4 100644
> --- a/test/serialization/ipa_data_serializer_test.cpp
> +++ b/test/serialization/ipa_data_serializer_test.cpp
> @@ -29,7 +29,7 @@ using namespace std;
> using namespace libcamera;
>
> static const ControlInfoMap Controls = ControlInfoMap({
> - { &controls::AeEnable, ControlInfo(false, true) },
> + { &controls::ExposureTimeMode, ControlInfo(false, true) },
The ExposureTimeMode control is an enum, not a boolean control.
You could use AwbEnable instead, although that may disappear in the
future as it gets reworked in a similar way as the AGC controls.
DebugMetadataEnable is another option.
> { &controls::ExposureTime, ControlInfo(0, 999999) },
> { &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },
> { &controls::ColourGains, ControlInfo(0.0f, 32.0f) },
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list