[PATCH v2 0/4] Add support for Sony IMX327 and IMX462 sensors

[Dave Stevenson]

Hi David

On Tue, 19 Nov 2024 at 09:21, David Plowman
<david.plowman at raspberrypi.com> wrote:
>
> Hi Geoffrey
>
> Thanks for the update!
>
> On Mon, 18 Nov 2024 at 22:53, Geoffrey Van Landeghem
> <geoffrey.vl at gmail.com> wrote:
> >
> > Hi,
> > This patch-set comes as part of an ongoing effort to support Sony IMX327 and IMX462 sensors better in the linux kernel.
> > For the kernel, following changes are proposed upstream:
> >
> > https://lore.kernel.org/linux-media/20241114-media-imx290-imx462-v1-0-c538a2e24786@raspberrypi.com/
> >
> > Also discussed here:
> > https://github.com/raspberrypi/linux/pull/5859
> >
> > After those changes have been applied, the 2 Starvis sensors will no longer be identied by libcamera as a IMX290 and therefore require this patch-set to work correctly.
> >
> > Thanks,
> > Geoffrey
> >
> > Geoffrey Van Landeghem (4):
> >   libcamera: libipa: camera_sensor: Provide CameraSensorHelper and
> >     CameraSensorProperties for the Sony IMX462 image sensor.
> >   ipa: rpi: cam_helper: Add Sony IMX327
> >   ipa: raspberrypi: Add tuning file for IMX462 sensor
> >   ipa: raspberrypi: Add tuning file for IMX327 sensor
> >
> >  src/ipa/libipa/camera_sensor_helper.cpp       |   5 +
> >  src/ipa/rpi/cam_helper/cam_helper_imx290.cpp  |   2 +
> >  src/ipa/rpi/vc4/data/imx327.json              | 215 ++++++++++++++++++
> >  src/ipa/rpi/vc4/data/imx462.json              | 215 ++++++++++++++++++
> >  src/ipa/rpi/vc4/data/meson.build              |   2 +
> >  .../sensor/camera_sensor_properties.cpp       |   4 +
> >  6 files changed, 443 insertions(+)
> >  create mode 100644 src/ipa/rpi/vc4/data/imx327.json
> >  create mode 100644 src/ipa/rpi/vc4/data/imx462.json
> >
> > --
> > 2.43.0
> >
>
> I guess I'm a bit curious just how similar these sensors are the the
> 290, but I'm fine with this support, so perhaps I can add

AIUI IMX327 came first, doing up to 1080p60 as 10 or 12 bit.
IMX290 was added with 1080p120 support, but only as 10 bit.
IMX462 does minor tweaks. The flyer claimed 1080p120 as 12 bit, but
I've had it confirmed that that is not supported.

All have near identical register sets. Copies of all the datasheets
should be on samba\shared.
The driver doesn't support the 120fps modes at all.

I have colour samples of all 3 and a mono imx290 if you wanted to do a
proper tuning on all of them :-)

  Dave

> Reviewed-by: David Plowman <david.plowman at raspberrypi.com>
>
> to all the patches in this set.
>
> Thanks!
> David