[PATCH v2 1/8] libcamera: rkisp1: Fix scope of dewarper stop() exit action

[Jacopo Mondi]

Hi Stefan

On Mon, Nov 25, 2024 at 04:14:10PM +0100, Stefan Klug wrote:
> Move the definition of the dewarper stop() action into the scope were
> the corresponding start() happens.
>
> Fixes: 12b553d691d4 ("libcamera: rkisp1: Plumb the dw100 dewarper as V4L2M2M converter")
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
>

Extraneous blank line ;)

> Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>
> Reviewed-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 6c6d711f91b3..5ffcfbce56be 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -1043,8 +1043,8 @@ int PipelineHandlerRkISP1::start(Camera *camera, [[maybe_unused]] const ControlL
>  				LOG(RkISP1, Error) << "Failed to start dewarper";
>  				return ret;
>  			}
> +			actions += [&]() { dewarper_->stop(); };
>  		}
> -		actions += [&]() { dewarper_->stop(); };
>  	}
>
>  	if (data->mainPath_->isEnabled()) {
> --
> 2.43.0
>