[PATCH v5 0/2] Add camera sensor properties for ciri

[Cheng-Hao Yang]

Hi Kieran,

On Fri, Nov 29, 2024 at 12:32 AM Kieran Bingham
<kieran.bingham at ideasonboard.com> wrote:
>
> Hi Harvey,
>
>
> Quoting Harvey Yang (2024-11-21 08:57:15)
> > Hi folks,
> >
> > This patch adds camera sensor properties for sensors on mtkisp7. It's
> > required to produce correct color bars test pattern instead of random
> > pattern.
> >
> > Tested on mtkisp7 branch with ChromeOS tast test `camera.HAL3Frame`.
> >
> > This patch passed gitlab pipeline:
> > https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1313611
> >
> > The source file includes quite some legacy code that has linter
> > warnings. This patch follows the same legacy format, so there are some
> > lint warnings as well.
> >
> > v5:
> > - Fixed the conversion from RAW10 to RAW16 for black levels.
>
> Thanks,
>
> I'm trying to merge these - But I'm afraid you lost the race against
> Dan's series which now adds the sensor control delays to the camera
> sensor helpers.
>
> If you know the delays could you add those in please?
>
> If not - please add in an empty structure so that it will use the
> defaults and report that they are unknown.

Yes, all of the delays are 2.
Updated in v6.

BR,
Harvey

>
> --
> Kieran
>
>
> >
> > v4:
> > - Added black level values.
> >
> > v3:
> > - Updated commit messages.
> > - Added proper linear conversion rules for the two sensors.
> >
> > v2:
> > - Removed hi1339 that was not upstreamed and deprecated.
> > - Added CameraSensorHelper implementations, while might not end up
> >   using.
> > - Split into two patches for two sensors.
> >
> > BR,
> > Harvey
> >
> > Harvey Yang (2):
> >   libcamera: libipa: camera_sensor: Add GalaxyCore gc05a2 sensor
> >     properties
> >   libcamera: libipa: camera_sensor: Add GalaxyCore gc08a3 sensor
> >     properties
> >
> >  src/ipa/libipa/camera_sensor_helper.cpp       | 26 +++++++++++++++++++
> >  .../sensor/camera_sensor_properties.cpp       | 14 ++++++++++
> >  2 files changed, 40 insertions(+)
> >
> > --
> > 2.47.0.338.g60cca15819-goog
> >