[PATCH v6 1/2] libcamera: libipa: camera_sensor: Add GalaxyCore gc05a2 sensor properties

[Kieran Bingham]

Hi Harvey,

Your e-mails are now breaking our CI tests. Technically this might be a
form of a false positive, but is there anythign we can do to prevent
this from happening? or could you fix this please?


Quoting Harvey Yang (2024-11-29 05:52:18)
> From: Harvey Yang <chenghaoyang at google.com>

Here you are from 'google'

> 
> Provide the GalaxyCore gc05a2 camera sensor properties and registration
> with libipa for the gain code helpers.
> 
> Signed-off-by: Han-Lin Chen <hanlinchen at chromium.org>
> Co-developed-by: Xing Gu <xinggu at chromium.org>
> Signed-off-by: Xing Gu <xinggu at chromium.org>
> Co-developed-by: Yudhistira Erlandinata <yerlandinata at chromium.org>
> Signed-off-by: Yudhistira Erlandinata <yerlandinata at chromium.org>
> Co-developed-by: Harvey Yang <chenghaoyang at chromium.org>
> Signed-off-by: Harvey Yang <chenghaoyang at chromium.org>

But no one at google has signed this commit - so the following test
fails.:

https://gitlab.freedesktop.org/camera/libcamera/-/jobs/67426810

Running Pre-merge checks for patchwork/4832 (4d9db06d669044c0c461a2aed79c85c7fe32a502..3eb97f403536c34edaecd42464637e44dd999cea) 00:17
Missing author Signed-off-by in commit 3eb97f403536c34edaecd42464637e44dd999cea
Missing author Signed-off-by in commit 26bc3bd1e4f7c767f98fb0d44572122e3f7adf8a
Found 2 errors in patchwork/4832, not pushing

--
Kieran


> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
>  src/ipa/libipa/camera_sensor_helper.cpp           | 13 +++++++++++++
>  src/libcamera/sensor/camera_sensor_properties.cpp | 13 +++++++++++++
>  2 files changed, 26 insertions(+)
> 
> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
> index a0a5437aa..9fb55bcfa 100644
> --- a/src/ipa/libipa/camera_sensor_helper.cpp
> +++ b/src/ipa/libipa/camera_sensor_helper.cpp
> @@ -519,6 +519,19 @@ private:
>  };
>  REGISTER_CAMERA_SENSOR_HELPER("ar0521", CameraSensorHelperAr0521)
>  
> +class CameraSensorHelperGc05a2 : public CameraSensorHelper
> +{
> +public:
> +       CameraSensorHelperGc05a2()
> +       {
> +               /* From datasheet: 64 at 10bits. */
> +               blackLevel_ = 4096;
> +               gainType_ = AnalogueGainLinear;
> +               gainConstants_.linear = { 100, 0, 0, 1024 };
> +       }
> +};
> +REGISTER_CAMERA_SENSOR_HELPER("gc05a2", CameraSensorHelperGc05a2)
> +
>  class CameraSensorHelperImx214 : public CameraSensorHelper
>  {
>  public:
> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp
> index 3fe18c164..73c47b9a1 100644
> --- a/src/libcamera/sensor/camera_sensor_properties.cpp
> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp
> @@ -106,6 +106,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>                         },
>                         .sensorDelays = { },
>                 } },
> +               { "gc05a2", {
> +                       .unitCellSize = { 1120, 1120 },
> +                       .testPatternModes = {
> +                               { controls::draft::TestPatternModeOff, 0 },
> +                               { controls::draft::TestPatternModeColorBars, 1 },
> +                       },
> +                       .sensorDelays = {
> +                               .exposureDelay = 2,
> +                               .gainDelay = 2,
> +                               .vblankDelay = 2,
> +                               .hblankDelay = 2
> +                       },
> +               } },
>                 { "hi846", {
>                         .unitCellSize = { 1120, 1120 },
>                         .testPatternModes = {
> -- 
> 2.47.0.338.g60cca15819-goog
>