[PATCH 15 7/7] libcamera: software_isp: Refactor SoftwareIsp to use DmaBufAllocator::exportBuffers
Harvey Yang
chenghaoyang at chromium.org
Fri Oct 4 11:59:20 CEST 2024
As the helper function DmaBufAllocator::exportBuffers is added, we can
avoid some code duplication in SoftwareIsp as well.
Signed-off-by: Harvey Yang <chenghaoyang at chromium.org>
Reviewed-by: Milan Zamazal <mzamazal at redhat.com>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
src/libcamera/software_isp/software_isp.cpp | 20 +-------------------
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp
index 47677784d..5f58e5e40 100644
--- a/src/libcamera/software_isp/software_isp.cpp
+++ b/src/libcamera/software_isp/software_isp.cpp
@@ -256,25 +256,7 @@ int SoftwareIsp::exportBuffers(const Stream *stream, unsigned int count,
if (stream == nullptr)
return -EINVAL;
- for (unsigned int i = 0; i < count; i++) {
- const std::string name = "frame-" + std::to_string(i);
- const size_t frameSize = debayer_->frameSize();
-
- FrameBuffer::Plane outPlane;
- outPlane.fd = SharedFD(dmaHeap_.alloc(name.c_str(), frameSize));
- if (!outPlane.fd.isValid()) {
- LOG(SoftwareIsp, Error)
- << "failed to allocate a dma_buf";
- return -ENOMEM;
- }
- outPlane.offset = 0;
- outPlane.length = frameSize;
-
- std::vector<FrameBuffer::Plane> planes{ outPlane };
- buffers->emplace_back(std::make_unique<FrameBuffer>(std::move(planes)));
- }
-
- return count;
+ return dmaHeap_.exportBuffers(count, { debayer_->frameSize() }, buffers);
}
/**
--
2.47.0.rc0.187.ge670bccf7e-goog
More information about the libcamera-devel
mailing list