[PATCH v14 6/7] libcamera: virtual: Read config and register cameras based on the config

[Cheng-Hao Yang]

Hi Laurent,

On Tue, Oct 8, 2024 at 2:54 AM Laurent Pinchart
<laurent.pinchart at ideasonboard.com> wrote:
>
> On Fri, Oct 04, 2024 at 06:00:36PM +0800, Cheng-Hao Yang wrote:
> > Hi Kieran,
> >
> > On Thu, Oct 3, 2024 at 7:51 PM Kieran Bingham
> > <kieran.bingham at ideasonboard.com> wrote:
> > >
> > > Quoting Harvey Yang (2024-09-30 07:29:47)
> > > > This patch introduces the configuration file for Virtual Pipeline
> > > > Handler. The config file is written in yaml, and the format is
> > > > documented in `README.md`.
> > > >
> > > > The config file will define the camera with IDs, supported formats and
> > > > image sources, etc. In the default config file, only Test Patterns are
> > > > used. Developers can use real images loading if desired.
> > > >
> > > > Signed-off-by: Konami Shu <konamiz at google.com>
> > > > Co-developed-by: Harvey Yang <chenghaoyang at chromium.org>
> > >
> > > CI complains that you don't have an explicit SoB tag here, but you're
> > > listed as the Author.
> > >
> > > I think that's on another patch too... something to look for.
> >
> > Maybe it presumes the SoB should also be the committer...
>
> Both the author and the committer of a commit need to have a SoB line.
> Anybody listed as a co-author with Co-developed-by also needs a SoB
> nice. Quoting the kernel documentation,
>
>  - Co-developed-by: states that the patch was co-created by several developers;
>    it is a used to give attribution to co-authors (in addition to the author
>    attributed by the From: tag) when multiple people work on a single patch.
>    Every Co-developed-by: must be immediately followed by a Signed-off-by: of
>    the associated co-author.

Got it. Thanks!

Linter passes: https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1285528

I'll upload another version with other comments fixed and
review tags to prevent the spam.

BR,
Harvey

>
> > > > Co-developed-by: Yunke Cao <yunkec at chromium.org>
> > > > Co-developed-by: Tomasz Figa <tfiga at chromium.org>
> > > > ---
> > > >  src/libcamera/pipeline/virtual/README.md      |  48 ++++
> > > >  .../pipeline/virtual/data/virtual.yaml        |  36 +++
> > > >  .../virtual/image_frame_generator.cpp         |  16 +-
> > > >  .../pipeline/virtual/image_frame_generator.h  |   5 +-
> > > >  src/libcamera/pipeline/virtual/meson.build    |   1 +
> > > >  src/libcamera/pipeline/virtual/parser.cpp     | 260 ++++++++++++++++++
> > > >  src/libcamera/pipeline/virtual/parser.h       |  39 +++
> > > >  src/libcamera/pipeline/virtual/virtual.cpp    | 122 ++++----
> > > >  src/libcamera/pipeline/virtual/virtual.h      |  21 +-
> > > >  9 files changed, 483 insertions(+), 65 deletions(-)
> > > >  create mode 100644 src/libcamera/pipeline/virtual/README.md
> > > >  create mode 100644 src/libcamera/pipeline/virtual/data/virtual.yaml
> > > >  create mode 100644 src/libcamera/pipeline/virtual/parser.cpp
> > > >  create mode 100644 src/libcamera/pipeline/virtual/parser.h
>
> [snip]
>
> --
> Regards,
>
> Laurent Pinchart