[PATCH v5 0/1] rkisp1: Integrate sensorConfiguration
Umang Jain
umang.jain at ideasonboard.com
Tue Oct 8 12:19:17 CEST 2024
1/1 integrates sensor configuration in rkisp1.
Changes in v5:
- on RAW stream path, compare sensorFormat's size returned
from CameraSensor::getFormat() to streamConfiguration->outputsize
Changes in v4:
- Fix bitDepth handling in RkISP1Path
- Unify 2 if(sensorConfig) branches in RkISP1
- Remove {} (nits)
- maxResolution should be bounded first before bounding to
aspect ratio
- drop "std::optional" from bitDepth variable
Changes in v3:
- Drop isRaw() dependency
- rework commit message to elaborate cases of sensor configuration
failure
Changes in v2:
- Validate sensor resolution in RkISP1Path::validate() instead of RkISP1
- Pass sensorConfiguration by reference
- Do not adjust sensor Configuration, always return
CameraConfiguration::Invalid if sensor configuration cannot be
satisfied
- Apply sensor configuration at configure() time
v1:
- https://patchwork.libcamera.org/patch/21463/
- Developed over [PATCH] libcamera: rkisp1: Clamp stream configuration to ISP limit on raw path
- Tested with cam+[1] on i.MX8MP with IMX283 attached
[1]: https://patchwork.libcamera.org/patch/20080/
Umang Jain (1):
libcamera: rkisp1: Integrate SensorConfiguration support
src/libcamera/pipeline/rkisp1/rkisp1.cpp | 42 +++++++++++++---
src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 48 +++++++++++++++++--
src/libcamera/pipeline/rkisp1/rkisp1_path.h | 2 +
3 files changed, 80 insertions(+), 12 deletions(-)
--
2.45.0
More information about the libcamera-devel
mailing list