[PATCH] gitignore: Add venv directory to gitignore

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Oct 9 17:43:53 CEST 2024


On Wed, Oct 09, 2024 at 09:35:53AM +0100, Kieran Bingham wrote:
> Quoting Dan Scally (2024-10-09 08:33:05)
> > On 09/10/2024 08:16, Stefan Klug wrote:
> > > The python venv module is the standard way of creating virtual python
> > > environments. 'venv' is a commonly used name for the corresponding
> > > directory. For example in the tuning docs we propose to execute 'python
> > > -m venv venv' to setup a local virtual environment.  During development
> > > I often have these scattered around in the source tree and they show up
> > > as untracked files in git. Add venv to .gitignore to prevent that.
> > >
> > > Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
> > > ---
> 
> I would wonder if venv isn't just a global thing to ignore, but as we
> have python bindings in libcamera it might be slightly more relevant, so
> I don't specifically object.

I think venv is a better candidate for ~/.config/git/ignore, given that
the directory name is selected by users.

> Acked-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> 
> > Reviewed-by: Daniel Scally <dan.scally at ideasonboard.com>
> > >   .gitignore | 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/.gitignore b/.gitignore
> > > index f6d1d68e4a7c..51d3144085ce 100644
> > > --- a/.gitignore
> > > +++ b/.gitignore
> > > @@ -6,3 +6,4 @@
> > >   *.patch
> > >   *.pyc
> > >   __pycache__/
> > > +venv/

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list