[PATCH] Fix copyright year

Bernhard M. Wiedemann libcamerabmw+ml at lsmod.de
Thu Oct 10 11:28:29 CEST 2024


On 10/10/2024 10.51, Kieran Bingham wrote:
> Quoting libcamerabmw+ml at lsmod.de (2024-10-10 08:54:13)
>> From: "Bernhard M. Wiedemann" <bwiedemann at suse.de>
>> The diff was:
>> /usr/src/debug/libcamera-0.3.1/x86_64-suse-linux/include/libcamera/internal/tracepoints.h       2024-08-20 09:37:46.000000000 +0200
>> @@ -1,6 +1,6 @@
>>   /* SPDX-License-Identifier: LGPL-2.1-or-later */
>>   /*
>> - * Copyright (C) 2024, Google Inc.
>> + * Copyright (C) 2025, Google Inc.
> 
> This file is autogenerated right? So this 2025 isn't an issue in our
> commited code - but a build server with the wrong date at Suse?

It is my test script for reproducible-builds using qemu's -rtc base= 
option to simulate a clock that all computers will soon have anyway.

> If we set it from an mtime which is a good idea, it would probably be
> best to do so from the top level meson.build, as that's one file that
> can be guaranteed to be the same 'year' as the release. (because I
> modify that file to make the release).
> 
> Otherwise, you'd have to parse all of the input files and take the
> latest mtime. That could be a good option too. In fact that might be
> easier as you have a list of those files, while you don't have a
> reference to the meson.build...

Checking mtimes has the disadvantage that applying any downstream patch 
in our distribution would update it and thereby re-introduce this variation.
A constant year is really the simplest and most reliable solution.

Ciao
Bernhard M.


More information about the libcamera-devel mailing list