[PATCH 0/3] libcamera: controls: Add namespace to ControlId

Laurent Pinchart laurent.pinchart at ideasonboard.com
Thu Oct 10 22:05:28 CEST 2024


On Thu, Oct 10, 2024 at 05:47:16PM +0900, Paul Elder wrote:
> This series adds vendor (aka namespace) information to ControlId so that
> it can be queried by appliations, and presumably used to organize the UI
> with relation to control namespaces.
> 
> The word "vendor" is used instead of namespace, as it is what shows up
> in control_ranges.yaml, and also since it doesn't conflict with the C++
> keyword.

I was expecting "namespace" (or "ns") instead of "vendor", but "vendor"
makes sense, especially as it avoids the keyword clash.

> Paul Elder (3):
>   libcamera: controls: Add vendor information to ControlId
>   apps: cam: Print control vendor information when listing controls
>   py: Add bindings for ControlId vendor information
> 
>  include/libcamera/controls.h         |  8 ++++++--
>  src/apps/cam/camera_session.cpp      |  7 +++++--
>  src/libcamera/control_ids.cpp.in     |  4 ++--
>  src/libcamera/control_serializer.cpp |  2 +-
>  src/libcamera/controls.cpp           | 16 +++++++++++++---
>  src/libcamera/v4l2_device.cpp        |  2 +-
>  src/py/libcamera/py_main.cpp         |  1 +
>  7 files changed, 29 insertions(+), 11 deletions(-)

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list