[PATCH 1/2] libcamera: android: include token only in cros_mojo_token.h

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Oct 14 21:32:27 CEST 2024


Hi Harvey, Han-Lin,

Thank you for the patch.

On Mon, Oct 14, 2024 at 01:18:56PM +0000, Harvey Yang wrote:
> To avoid unnecessary dependency, especially on libchrome base, include
> only `cros-camera/camera_mojo_channel_manager_token.h` in
> `cros_mojo_token.h`.
> 
> Signed-off-by: Harvey Yang <chenghaoyang at chromium.org>
> Co-developed-by: Han-Lin Chen <hanlinchen at chromium.org>
> Signed-off-by: Han-Lin Chen <hanlinchen at chromium.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/android/cros_mojo_token.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/android/cros_mojo_token.h b/src/android/cros_mojo_token.h
> index d0baa80fc..fc57205a8 100644
> --- a/src/android/cros_mojo_token.h
> +++ b/src/android/cros_mojo_token.h
> @@ -7,6 +7,6 @@
>  
>  #pragma once
>  
> -#include <cros-camera/cros_camera_hal.h>
> +#include <cros-camera/camera_mojo_channel_manager_token.h>
>  
>  inline cros::CameraMojoChannelManagerToken *gCrosMojoToken = nullptr;

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list