[PATCH v2 2/3] apps: cam: Print control vendor information when listing controls

Paul Elder paul.elder at ideasonboard.com
Wed Oct 16 13:19:42 CEST 2024


Now that the vendor of the control can be queried, print it in
--list-controls.

Example output:
$ cam -c 1 --list-controls
Using camera platform/vimc.0 Sensor B as cam0
Control: libcamera::Brightness: [-1.000000..1.000000]
Control: libcamera::Contrast: [0.000000..2.000000]
Control: libcamera::Saturation: [0.000000..2.000000]

Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

---
No change in v2
---
 src/apps/cam/camera_session.cpp | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp
index edc49b875450..6e9890ccfda1 100644
--- a/src/apps/cam/camera_session.cpp
+++ b/src/apps/cam/camera_session.cpp
@@ -160,10 +160,13 @@ void CameraSession::listControls() const
 {
 	for (const auto &[id, info] : camera_->controls()) {
 		if (info.values().empty()) {
-			std::cout << "Control: " << id->name() << ": "
+			std::cout << "Control: "
+				  << id->vendor() << "::" << id->name() << ": "
 				  << info.toString() << std::endl;
 		} else {
-			std::cout << "Control: " << id->name() << ":" << std::endl;
+			std::cout << "Control: "
+				  << id->vendor() << "::" << id->name() << ":"
+				  << std::endl;
 			for (const auto &value : info.values()) {
 				int32_t val = value.get<int32_t>();
 				const auto &it = id->enumerators().find(val);
-- 
2.39.2



More information about the libcamera-devel mailing list