[PATCH v3 0/7] Raspberry Pi: Add controls::rpi::ScalerCrops

[Naushir Patuck]

Another gentle ping for the patches below.


On Tue, 8 Oct 2024 at 12:30, Naushir Patuck <naush at raspberrypi.com> wrote:

> Hi all,
>
> Patches 1/7 and 7/7 in this series need one more R-B tag then would be
> ready to merge.  Would somebody be able to have a look at them please?
>
> Thanks!
> Naush
>
>
> On Thu, 3 Oct 2024 at 08:53, Naushir Patuck <naush at raspberrypi.com> wrote:
> >
> > Hi,
> >
> > Version 3 of this work is functionally identical to v2, but with the
> following
> > minor changes:
> >
> > - Update the control documentation to reflect the priority of
> rpi::ScalerCrops
> >   over the ScalerCrop control.
> > - Remove the default constructor of CropParams, requiring replacing
> cropParams_[n]
> >   accessor with cropsParams_.at(n) in the pipeline handler code.
> >
> > Thanks,
> > Naush
> >
> > Naushir Patuck (7):
> >   controls: rpi: Add a vendor rpi::ScalerCrops control
> >   pipeline: rpi: Remove CameraData::scalerCrop_
> >   pipeline: rpi: Pass crop rectangle as a parameter to
> >     platformSetIspCrop()
> >   pipeline: rpi: Introduce CameraData::CropParams
> >   pipeline: rpi: Track which ISP output is configured for a stream
> >   pipeline: rpi: Pass ISP output index into platformSetIspCrop()
> >   pipeline: rpi: Handler controls::rpi::ScalerCrops
> >
> >  src/ipa/rpi/common/ipa_base.cpp               | 14 +++
> >  src/libcamera/control_ids_rpi.yaml            | 25 +++++
> >  .../pipeline/rpi/common/pipeline_base.cpp     | 94 +++++++++++++------
> >  .../pipeline/rpi/common/pipeline_base.h       | 22 ++++-
> >  src/libcamera/pipeline/rpi/vc4/vc4.cpp        | 17 +++-
> >  5 files changed, 136 insertions(+), 36 deletions(-)
> >
> > --
> > 2.34.1
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20241016/cfa8310b/attachment.htm>