[PATCH v1 3/4] libcamera: controls: Add missing size to control_type<Point>
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Wed Oct 16 16:40:10 CEST 2024
Hi Stefan,
Thank you for the patch.
On Tue, Oct 15, 2024 at 10:38:14PM +0200, Stefan Klug wrote:
> The size member is missing in control_type<Point>. Add it.
You may want to describe here what issue(s) this causes.
> Fixes: 200d535ca85f ("libcamera: controls: Add ControlTypePoint")
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> include/libcamera/controls.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h
> index ca60bbacad17..28fec767fae1 100644
> --- a/include/libcamera/controls.h
> +++ b/include/libcamera/controls.h
> @@ -101,6 +101,7 @@ struct control_type<Size> {
> template<>
> struct control_type<Point> {
> static constexpr ControlType value = ControlTypePoint;
> + static constexpr std::size_t size = 0;
> };
>
> template<typename T, std::size_t N>
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list