[PATCH v2 3/4] libcamera: controls: Add missing size to control_type<Point>

Stefan Klug stefan.klug at ideasonboard.com
Fri Oct 18 16:58:37 CEST 2024


The size member is missing in control_type<Point>. This did not do any
harm because the only control using the Point type was an array control.
As soon as a control-id with a non-array Point control gets defined, the
compile fails with:

error: size is not a member of libcamera::details::control_type<libcamera::Point>

Fixes: 200d535ca85f ("libcamera: controls: Add ControlTypePoint")
Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

---
Changes in v2:
- Describe the error in commit message
- Collected tags
---
 include/libcamera/controls.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h
index ca60bbacad17..28fec767fae1 100644
--- a/include/libcamera/controls.h
+++ b/include/libcamera/controls.h
@@ -101,6 +101,7 @@ struct control_type<Size> {
 template<>
 struct control_type<Point> {
 	static constexpr ControlType value = ControlTypePoint;
+	static constexpr std::size_t size = 0;
 };
 
 template<typename T, std::size_t N>
-- 
2.43.0



More information about the libcamera-devel mailing list