[PATCH] Add .editorconfig file

Kieran Bingham kieran.bingham at ideasonboard.com
Sun Oct 20 13:09:48 CEST 2024


Quoting Robert Mader (2024-10-19 14:16:06)
> To make contributing to libcamera more fun, see
> https://editorconfig.org/
> 
> Signed-off-by: Robert Mader <robert.mader at collabora.com>
> ---
>  .editorconfig | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 .editorconfig
> 
> diff --git a/.editorconfig b/.editorconfig
> new file mode 100644
> index 00000000..4599ce24
> --- /dev/null
> +++ b/.editorconfig
> @@ -0,0 +1,21 @@
> +# SPDX-License-Identifier: CC0-1.0
> +
> +root = true
> +
> +[*]
> +charset = utf-8
> +end_of_line = lf
> +trim_trailing_whitespace = true
> +
> +[*.{cpp,h}]
> +indent_size = 8
> +indent_style = tab
> +insert_final_newline = true
> +
> +[*.xml]
> +indent_size = 2
> +indent_style = space
> +
> +[meson.build]
> +indent_size = 2
> +indent_style = space
> \ No newline at end of file


We have 'insert_final_newline' on cpp and .h files which I think is
good, but here in this file - theres' no final newline right? Maybe we
should add that globally? 

We have python code too. Should we add in the reference from
editorconfig for


[*.py]
indent_style = space
indent_size = 4

? or is that default ?


It's cheap to add this:



Acked-by: Kieran Bingham <kieran.bingham at ideasonboard.com>


> -- 
> 2.47.0
>


More information about the libcamera-devel mailing list