[PATCH] libcamera: rkisp1: Create main buffer pool out of if(!isRaw)

Jacopo Mondi jacopo.mondi at ideasonboard.com
Mon Oct 28 11:15:23 CET 2024


The "useDewarper_" class variable is set to true during configure
only if the configuration is !isRaw.

The main path buffer pool creation can thus be moved out of the
if (!isRaw) block at allocateBuffers() time.

Cosmetic change that will make it easier to create a buffer pool
for the main and self paths unconditionally in future.

Signed-off-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
---
 src/libcamera/pipeline/rkisp1/rkisp1.cpp | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
index 83b74b27652f..20fb9765727f 100644
--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
@@ -927,16 +927,16 @@ int PipelineHandlerRkISP1::allocateBuffers(Camera *camera)
 		ret = stat_->allocateBuffers(maxCount, &statBuffers_);
 		if (ret < 0)
 			goto error;
+	}
 
-		/* If the dewarper is being used, allocate internal buffers for ISP. */
-		if (useDewarper_) {
-			ret = mainPath_.exportBuffers(maxCount, &mainPathBuffers_);
-			if (ret < 0)
-				goto error;
+	/* If the dewarper is being used, allocate internal buffers for ISP. */
+	if (useDewarper_) {
+		ret = mainPath_.exportBuffers(maxCount, &mainPathBuffers_);
+		if (ret < 0)
+			goto error;
 
-			for (std::unique_ptr<FrameBuffer> &buffer : mainPathBuffers_)
-				availableMainPathBuffers_.push(buffer.get());
-		}
+		for (std::unique_ptr<FrameBuffer> &buffer : mainPathBuffers_)
+			availableMainPathBuffers_.push(buffer.get());
 	}
 
 	for (std::unique_ptr<FrameBuffer> &buffer : paramBuffers_) {
-- 
2.47.0



More information about the libcamera-devel mailing list