[PATCH v2] libcamera: formats: Change bytesPerGroup of RGB565 and RGB565_BE from 3 to 2
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Mon Oct 28 17:35:26 CET 2024
Hi Hou,
Thank you for the patch.
On Mon, Oct 28, 2024 at 12:04:28PM +0900, Hou Qi wrote:
> The RGB565 and RGB565_BE formats incorrectly specify a wrong value
> of 3 bytes per group of pixels, when they actually use 2. Fix them.
>
> Signed-off-by: Hou Qi <qi.hou at nxp.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> src/libcamera/formats.cpp | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp
> index dbefb094..bfcdfc08 100644
> --- a/src/libcamera/formats.cpp
> +++ b/src/libcamera/formats.cpp
> @@ -157,7 +157,7 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{
> .colourEncoding = PixelFormatInfo::ColourEncodingRGB,
> .packed = false,
> .pixelsPerGroup = 1,
> - .planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},
> + .planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},
> } },
> { formats::RGB565_BE, {
> .name = "RGB565_BE",
> @@ -167,7 +167,7 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{
> .colourEncoding = PixelFormatInfo::ColourEncodingRGB,
> .packed = false,
> .pixelsPerGroup = 1,
> - .planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},
> + .planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},
> } },
> { formats::BGR888, {
> .name = "BGR888",
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list