[PATCH v2 01/20] tests: Add a missing iostream include

[Laurent Pinchart]

On Mon, Sep 02, 2024 at 11:49:52AM +0200, Milan Zamazal wrote:
> Laurent Pinchart writes:
> > On Fri, Aug 30, 2024 at 05:26:58PM +0200, Milan Zamazal wrote:
> >> generated_serializer_test.cpp uses iostream without including it,
> >> relying on imports from another included header.  Let's include iostream
> >
> > Double space.
> 
> This is intentional.  Emacs uses this (American?) style to distinguish
> sentences from abbreviations (and there are opinions that it is better
> readable on computer screens).  I don't use it in source code comments
> but use it elsewhere.

So the Americans messed up not just the spelling, for also the
typography ? :-) Jokes aside, you should switch to vim. Jokes aside
again, I won't insist on reformatting commit messages for that, even if
it looks completely alien to me (and thus hinders readability). It would
be more annoying in comments in code or in documentation.

> >> there.
> >> 
> >> Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> >
> >> ---
> >>  .../generated_serializer/generated_serializer_test.cpp           | 1 +
> >>  1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/test/serialization/generated_serializer/generated_serializer_test.cpp b/test/serialization/generated_serializer/generated_serializer_test.cpp
> >> index 4b11d67f..dd696885 100644
> >> --- a/test/serialization/generated_serializer/generated_serializer_test.cpp
> >> +++ b/test/serialization/generated_serializer/generated_serializer_test.cpp
> >> @@ -6,6 +6,7 @@
> >>   */
> >>  
> >>  #include <algorithm>
> >> +#include <iostream>
> >>  #include <tuple>
> >>  #include <vector>
> >>  

-- 
Regards,

Laurent Pinchart