[PATCH v3 06/18] libcamera: rkisp1: Formatting improvements
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Mon Sep 2 20:49:14 CEST 2024
On Mon, Sep 02, 2024 at 05:41:59PM +0200, Milan Zamazal wrote:
> The LSP autoformatter doesn't like some of the current formatting, let's
> make it happier. Note that not all of its suggestions were accepted
> because readability is preferred and adjusting .clang-format may not be
> easy or possible.
>
> Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> src/ipa/rkisp1/algorithms/awb.cpp | 3 ++-
> src/ipa/rkisp1/rkisp1.cpp | 4 ++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp
> index c6451719..955a9ff4 100644
> --- a/src/ipa/rkisp1/algorithms/awb.cpp
> +++ b/src/ipa/rkisp1/algorithms/awb.cpp
> @@ -306,7 +306,8 @@ void Awb::process(IPAContext &context,
> activeState.awb.gains.automatic.blue = blueGain;
> activeState.awb.gains.automatic.green = 1.0;
>
> - LOG(RkISP1Awb, Debug) << std::showpoint
> + LOG(RkISP1Awb, Debug)
> + << std::showpoint
> << "Means [" << redMean << ", " << greenMean << ", " << blueMean
> << "], gains [" << activeState.awb.gains.automatic.red << ", "
> << activeState.awb.gains.automatic.green << ", "
> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> index a62fe151..f164d7c5 100644
> --- a/src/ipa/rkisp1/rkisp1.cpp
> +++ b/src/ipa/rkisp1/rkisp1.cpp
> @@ -165,8 +165,8 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,
> return -ENODEV;
> }
>
> - context_.configuration.sensor.lineDuration = sensorInfo.minLineLength
> - * 1.0s / sensorInfo.pixelRate;
> + context_.configuration.sensor.lineDuration =
> + sensorInfo.minLineLength * 1.0s / sensorInfo.pixelRate;
>
> /* Load the tuning data file. */
> File file(settings.configurationFile);
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list