[PATCH v3] libcamera: Make FrameBuffer status default to FrameError

Harvey Yang chenghaoyang at chromium.org
Mon Sep 9 11:14:29 CEST 2024


From: Han-Lin Chen <hanlinchen at chromium.org>

To make sure platforms follow V4L2 spec and frame buffers go through
V4L2VideoDevice, setting default values to FrameMetadata's member
variables. Especially, status is defaulted to be FrameError.

Signed-off-by: Han-Lin Chen <hanlinchen at chromium.org>
Co-developed-by: Harvey Yang <chenghaoyang at chromium.org>
---
 include/libcamera/framebuffer.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h
index ff839243..ececc123 100644
--- a/include/libcamera/framebuffer.h
+++ b/include/libcamera/framebuffer.h
@@ -32,9 +32,9 @@ struct FrameMetadata {
 		unsigned int bytesused;
 	};
 
-	Status status;
-	unsigned int sequence;
-	uint64_t timestamp;
+	Status status = FrameError;
+	unsigned int sequence = 0;
+	uint64_t timestamp = 0;
 
 	Span<Plane> planes() { return planes_; }
 	Span<const Plane> planes() const { return planes_; }
-- 
2.46.0.469.g59c65b2a67-goog



More information about the libcamera-devel mailing list