[PATCH 0/3] qcam: Fix GL renderer on Qt 6

Neal Gompa neal at gompa.dev
Thu Sep 12 10:45:19 CEST 2024


On Wed, Sep 11, 2024 at 1:47 AM Laurent Pinchart
<laurent.pinchart at ideasonboard.com> wrote:
>
> Hello,
>
> This small series fixes the GL render with Qt 6. The fix is actually in
> patch 1/3 only, with patches 2/3 and 3/3 bringing additional cleanups
> and improvements.
>
> Laurent Pinchart (3):
>   qcam: viewfinder_gl: Fix binding of vertex buffer and shader program
>   qcam: viewfinder_gl: Drop duplicate glClearColor()
>   qcam: viewfinder_gl: Render image centered in letterbox
>
>  src/apps/qcam/assets/shader/bayer_8.vert  |  4 +-
>  src/apps/qcam/assets/shader/identity.vert |  3 +-
>  src/apps/qcam/viewfinder_gl.cpp           | 54 ++++++++++++++---------
>  src/apps/qcam/viewfinder_gl.h             |  2 +-
>  4 files changed, 39 insertions(+), 24 deletions(-)
>
>
> base-commit: f75b8dd26feaca86701704390dea18c71e2f0350
> --

LGTM.

Reviewed-by: Neal Gompa <neal at gompa.dev>


-- 
真実はいつも一つ!/ Always, there's only one truth!


More information about the libcamera-devel mailing list