[PATCH 2/4] libcamera: pipeline: rkisp1: Fix typo in todo task

Umang Jain umang.jain at ideasonboard.com
Fri Sep 27 09:29:46 CEST 2024


Hi Kieran,

Thank you for the patch.

On 16/09/24 7:32 pm, Kieran Bingham wrote:
> The delay values should be managed correctly. Not the dealys.
>
> Correct accordingly, but I also hope we'll resolve this
> task soon too.
>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
> ---
>   src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index c02c7cf374e9..2fee84e56d4d 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -1103,7 +1103,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)
>   	data->properties_ = data->sensor_->properties();
>   
>   	/*
> -	 * \todo Read dealy values from the sensor itself or from a
> +	 * \todo Read delay values from the sensor itself or from a
>   	 * a sensor database. For now use generic values taken from
>   	 * the Raspberry Pi and listed as generic values.
>   	 */



More information about the libcamera-devel mailing list