[PATCH v4 12/15] config: Allow enabling software ISP in runtime

[Milan Zamazal]

Hi Barnabás,

Barnabás Pőcze <pobrn at protonmail.com> writes:

> Hi
>
>
> 2024. szeptember 25., szerda 11:58 keltezéssel, Milan Zamazal <mzamazal at redhat.com> írta:
>
>> [...]
>>  	swIspEnabled_ = info->swIspEnabled;
>> +	for (GlobalConfiguration::Configuration entry :
>> +	     GlobalConfiguration::configuration()
>> +		     ["pipelines"]["simple"]["supported_devices"]
>> +			     .asList()) {
>> +		auto name = entry["driver"].get<std::string>();
>> +		if (name.has_value() and !name.value().compare(info->driver)) {
>
> I think
>
>   if (name == info->driver)
>
> should work.

OK, thank you, I'll fix it in v5.

> Regards,
> Barnabás Pőcze
>
>
>> +			swIspEnabled_ = entry["software_isp"].get<bool>().value_or(swIspEnabled_);
>> +			LOG(SimplePipeline, Debug) << "Overriding software ISP to " << swIspEnabled_;
>> +			break;
>> +		}
>> +	}
>> 
>>  	/* Locate the sensors. */
>>  	std::vector<MediaEntity *> sensors = locateSensors(media);
>> --
>> 2.44.1