[PATCH 5/5] test: ipa: libipa: histogram: Add tests for small inter quantile mean ranges

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Apr 1 00:09:27 CEST 2025


Hi Stefan,

Thank you for the patch.

On Mon, Mar 24, 2025 at 06:07:40PM +0100, Stefan Klug wrote:
> Add tests for small inter quantile mean ranges. These cases were
> fixed in the last commit.
> 
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
> ---
>  test/ipa/libipa/histogram.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/test/ipa/libipa/histogram.cpp b/test/ipa/libipa/histogram.cpp
> index b96626054af0..b0f9644cebc7 100644
> --- a/test/ipa/libipa/histogram.cpp
> +++ b/test/ipa/libipa/histogram.cpp
> @@ -55,6 +55,10 @@ protected:
>  		/* Test quantile means that are in the middle of the bins */
>  		ASSERT_EQ(hist.interQuantileMean(0.25, 0.75), 1.0);
>  
> +		/* Test small ranges at the borders of the histogram */

s/histogram/histogram./

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> +		ASSERT_EQ(hist.interQuantileMean(0.0, 0.1), 0.1);
> +		ASSERT_EQ(hist.interQuantileMean(0.9, 1.0), 1.9);
> +
>  		return TestPass;
>  	}
>  };

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list