[PATCH v2 1/3] ipa: libipa: Allow retrieving the name of a CameraSensorHelperFactory

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Apr 2 02:40:42 CEST 2025


Hi Paul,

Thank you for the patch.

On Wed, Mar 26, 2025 at 05:00:31PM +0900, Paul Elder wrote:
> From: Kieran Bingham <kieran.bingham at ideasonboard.com>
> 
> Support the test suite iterating the factories by exposing a const
> retriever of the factory name.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> ---
> Changes in v2:
> - recover from bitrot
> ---
>  src/ipa/libipa/camera_sensor_helper.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h
> index a9300a64f1e7..92f527108137 100644
> --- a/src/ipa/libipa/camera_sensor_helper.h
> +++ b/src/ipa/libipa/camera_sensor_helper.h
> @@ -60,6 +60,8 @@ public:
>  
>  	static std::vector<CameraSensorHelperFactoryBase *> &factories();
>  
> +	const std::string &name() const { return name_; };

Drop the final semicolon.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> +
>  private:
>  	LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase)
>  

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list